Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] l10n_it_riba: fix state update on riba lines #3885

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[16.0] l10n_it_riba: fix state update on riba lines #3885

merged 1 commit into from
Feb 5, 2024

Conversation

salvorapi
Copy link
Contributor

@salvorapi salvorapi commented Jan 24, 2024 •
edited
Loading

fix issue #3884

@robyf70 robyf70 mentioned this pull request Jan 24, 2024
Closed
2 tasks
@francesco-ooops francesco-ooops linked an issue Jan 25, 2024 that may be closed by this pull request
[16.0] l10n_it_riba: Azione "SEGNA TUTTE COME PAGATE" non funziona quando si seleziona su "SEGNA COME ACCREDITATA" il bottone "Salta e conferma accredito" su wizard. #3884
Open
2 tasks
@francesco-ooops
Copy link
Contributor

@salvorapi riesci ad aggiungere copertura funzionale al fix?

@salvorapi
Copy link
Contributor Author

@salvorapi riesci ad aggiungere copertura funzionale al fix?

Quello che succede è che l'operazione successiva di "Segna tutte come pagate" non fa nulla perché contiene delle righe Confermate mentre lo stato della Riba è "Accreditata".

Salvo.

@francesco-ooops
Copy link
Contributor

intendevo dei test per aumentare la copertura codecov :)

@francesco-ooops francesco-ooops mentioned this pull request Jan 26, 2024
Open
2 tasks
@salvorapi salvorapi force-pushed the 16.0-l10n_it_riba_fix_state_update_on_riba_lines branch 2 times, most recently from c564ec1 to 511de42 Compare January 26, 2024 18:18
@salvorapi
Copy link
Contributor Author

intendevo dei test per aumentare la copertura codecov :)

done. 😊

eLBati
eLBati approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Feb 2, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU
Copy link
Member

tafaRU commented Feb 2, 2024

@salvorapi grazie della PR! Se vuoi puoi aggiungerti tra in contributors. Per farlo devi editare https://github.com/OCA/l10n-italy/blob/fa5ea4dd0210d263609faf963f82ad26ba573ead/l10n_it_riba/readme/CONTRIBUTORS.rst

@salvorapi salvorapi force-pushed the 16.0-l10n_it_riba_fix_state_update_on_riba_lines branch from 511de42 to 1804ab3 Compare February 2, 2024 11:48
@salvorapi salvorapi force-pushed the 16.0-l10n_it_riba_fix_state_update_on_riba_lines branch from 1804ab3 to 171082c Compare February 2, 2024 13:18
@tafaRU
Copy link
Member

tafaRU commented Feb 5, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3885-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8b03a97 into OCA:16.0 Feb 5, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ed384bc. Thanks a lot for contributing to OCA. ❤️

@TheMule71 TheMule71 mentioned this pull request Nov 15, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

@tafaRU tafaRU tafaRU approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
6 participants
@salvorapi @francesco-ooops @OCA-git-bot @tafaRU @eLBati @MaurizioPellegrinet