Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMP l10n_it_account removing check_balance_sign_coherence. #4431

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Oct 30, 2024

This check can block chart of accounts configuration and is not mandatory. account_balance_sign is only used by l10n_it_financial_statements_report and, in case of incoherent signs, user can visualize the amounts in financial_statements_report and fix the sign, in case

@SirAionTech SirAionTech added the needs fixing Has conflicts or is failing mandatory CI checks label Oct 31, 2024
@eLBati eLBati marked this pull request as draft October 31, 2024 08:52
@eLBati eLBati force-pushed the 16.0-check_balance_sign_coherence branch 3 times, most recently from 8234f15 to 0e0c3c4 Compare October 31, 2024 09:31
…ng check_balance_sign_coherence.

account_balance_sign is now computed, based on account type.
Therefore many checks are now redundant
@eLBati eLBati force-pushed the 16.0-check_balance_sign_coherence branch from 0e0c3c4 to a559471 Compare October 31, 2024 09:39
@eLBati eLBati marked this pull request as ready for review October 31, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16.0 missing issue needs fixing Has conflicts or is failing mandatory CI checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants