[16.0][MIG] account_invoice_margin: Migration to v16 #163

ljsalvatierra-factorlibre · 2023-03-01T12:44:31Z

#142

legalsylvain · 2023-03-01T13:16:27Z

Hi. could you take a look on CI ?
thanks !

ljsalvatierra-factorlibre · 2023-03-01T13:30:16Z

Hi. could you take a look on CI ? thanks !

Hi, yes, i am resolving the issues.

ljsalvatierra-factorlibre · 2023-03-08T10:44:36Z

Hi, can anyone review this PR? Thanks in advance

pedrobaeza · 2023-03-08T10:46:46Z

You may find reviewers by chance if someone is interested, but a non selfish way of collaborating is to review other PRs, and ask in exchange that they review yours. When you are a good contributor, there will be other good contributors that will be will to make the reviews for free, but you have to equal the balance.

Anyway, if it's ready, remove the [WIP] label from the title.

ljsalvatierra-factorlibre · 2023-03-08T10:48:20Z

You may find reviewers by chance if someone is interested, but a non selfish way of collaborating is to review other PRs, and ask in exchange that they review yours. When you are a good contributor, there will be other good contributors that will be will to make the reviews for free, but you have to equal the balance.

Anyway, if it's ready, remove the [WIP] label from the title.

Totally agree with you, i'll see what i can do to improve that :)

legalsylvain · 2023-03-08T11:28:23Z

Pre-commit is still red. Could you take a look ?

ljsalvatierra-factorlibre · 2023-03-08T11:55:45Z

Pre-commit is still red. Could you take a look ?

Fixed, is it possible to re-run the tests with Odoo?

legalsylvain · 2023-03-08T12:54:06Z

if you rebase, it will rerun the CI.

ljsalvatierra-factorlibre · 2023-03-08T13:36:25Z

if you rebase, it will rerun the CI.

Yes, but it is already up to date.

ljsalvatierra-factorlibre · 2023-03-10T08:43:12Z

Fixed one of the README images name.

legalsylvain

Hi.

since OCA introduced _get_margin_applicable_lines features, margin can be computed correctly removing non relevant invoice lines. (down payment lines for example)

however, the sale_margin odoo module does'nt implement such feature and so the margin in sale.order can be wrong. (same for margin in pos.order) do you face the same issue ?
If yes do you have an idea how to fix it ?

thanks !

legalsylvain · 2023-03-10T09:44:15Z

account_invoice_margin/models/account_invoice.py

+            margin = 0.0
+            margin_signed = 0.0
+            price_subtotal = 0.0
+            for line in invoice._get_margin_applicable_lines():


Suggested change

for line in invoice._get_margin_applicable_lines():

for line in invoice.line_ids.filtered(lambda x: x.is_margin_applicable):

What about to have a compute field on account.invoice.line. I think that it's a caracteristic of the line.

Just a proposal, not a blocking point.

I'll take a look, thank you @legalsylvain for pointing it out.

Well, in fact, the ideal should be to have a uniq function _is_applicable_margin / _get_margin_applicable_lines or whatever that could be called in the account.move margin module / sale.order margin module / pos.order margin module.

But I'm not sure how to proceed.

Yadier-Tecnativa · 2023-04-27T14:29:28Z

ping @sergio-teruel and @pedrobaeza TT42417

pedrobaeza · 2023-04-27T15:31:01Z

/ocabot migration account_invoice_margin

gerard-vacas · 2023-05-23T08:01:43Z

Hi.

To the comment that posted @legalsylvain I would comment:

This module is designed to calculate the margin in invoices and although in sale orders the margin could not be correct, we have that:

Invoice will always recalculate margin from data in lines
Even if using the module account_invoice_margin_sale, wich transfers the cost of the line from SO to invoice, and as far as I know, cost of down payments will be 0 at any case, margin will be calculated correctly in invoices

Based on that, I consider that any fixes on sale order margins would be great but I doubt this module is the one for them.

Having said that, the module LGTM

Thanks

rafaelbn · 2023-05-25T21:29:01Z

Runbot not available to test, please @ljsalvatierra-factorlibre could you make a rebase or add an empty commit trying to wake up runboat? 😄

[UPD] README.rst [UPD] Update account_invoice_margin.pot Translated using Weblate (Spanish) Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-11.0/margin-analysis-11.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-11-0/margin-analysis-11-0-account_invoice_margin/es/

[UPD] README.rst

…t invoice margin security group set

The invoice may be done in a currency different from the company currency, so the cost (purchase_price) amount will be incorrect in such context. TT38500

ljsalvatierra-factorlibre · 2023-05-26T05:34:48Z

Runbot not available to test, please @ljsalvatierra-factorlibre could you make a rebase or add an empty commit trying to wake up runboat? smile

Done, thank you for the reminder! :)

account_invoice_margin/models/account_invoice.py

account_invoice_margin/tests/test_account_invoice_margin.py

Gelo-fl

Functional revision OK

OCA-git-bot · 2023-06-02T09:39:24Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

RodrigoBM · 2023-06-02T09:52:48Z

Is it possible to merge this PR? @OCA/accounting-maintainers

pedrobaeza · 2023-06-02T23:25:26Z

/ocabot merge nobump

OCA-git-bot · 2023-06-02T23:26:46Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-163-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-06-02T23:33:03Z

Congratulations, your PR was merged at e1f7b4d. Thanks a lot for contributing to OCA. ❤️

sergio-teruel · 2023-06-05T14:54:12Z

ping @Juangomezzurita

ljsalvatierra-factorlibre changed the title ~~[16.0][MIG] account_invoice_margin: Migration to v16~~ [WIP][16.0][MIG] account_invoice_margin: Migration to v16 Mar 1, 2023

ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_margin branch from 66009af to 1da762b Compare March 1, 2023 14:32

ljsalvatierra-factorlibre changed the title ~~[WIP][16.0][MIG] account_invoice_margin: Migration to v16~~ [16.0][MIG] account_invoice_margin: Migration to v16 Mar 8, 2023

ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_margin branch 2 times, most recently from 9d1ac7b to f6d4953 Compare March 8, 2023 11:51

ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_margin branch from f6d4953 to 83ac83d Compare March 10, 2023 08:40

legalsylvain reviewed Mar 10, 2023

View reviewed changes

ljsalvatierra-factorlibre mentioned this pull request Mar 13, 2023

[16.0][MIG] account_invoice_margin_sale: Migration to 16.0 #165

Merged

OCA-git-bot added this to the 16.0 milestone Apr 27, 2023

OCA-git-bot mentioned this pull request Apr 27, 2023

Migration to version 16.0 #142

Open

10 tasks

JavierIniesta approved these changes May 25, 2023

View reviewed changes

sergio-teruel and others added 5 commits May 26, 2023 07:34

[9.0][WIP] account_invoice_margin: New module

7eb0c61

[MIG] account_invoice_margin: Migration to v11

8f17b39

[11.0][IMP] account_invoice_margin: Minor fix in the same PR

4da941c

[UPD] README.rst

[FIX] account_invoice_margin: Set purchase_price when user has not se…

d34c9b6

…t invoice margin security group set

OCA-git-bot and others added 7 commits May 26, 2023 07:34

account_invoice_margin 14.0.1.0.1

ea78da2

[MIG] account_invoice_margin: Migration to 15.0

328f6ba

[UPD] Update account_invoice_margin.pot

0dd9ccc

[UPD] README.rst

393588e

[FIX] account_invoice_margin: Take currency into account

189f362

The invoice may be done in a currency different from the company currency, so the cost (purchase_price) amount will be incorrect in such context. TT38500

account_invoice_margin 15.0.1.0.1

071b978

[IMP] account_invoice_margin: pre-commit stuff

cd73bf4

ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_margin branch from 83ac83d to b241bed Compare May 26, 2023 05:34

RodrigoBM suggested changes Jun 1, 2023

View reviewed changes

Gelo-fl approved these changes Jun 2, 2023

View reviewed changes

ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_margin branch 2 times, most recently from 1b725e2 to 820a3ae Compare June 2, 2023 07:03

[MIG] account_invoice_margin: Migration to 16.0

82a1784

ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_margin branch from 820a3ae to 82a1784 Compare June 2, 2023 09:35

RodrigoBM approved these changes Jun 2, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 2, 2023

JavierIniesta approved these changes Jun 2, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 2, 2023

OCA-git-bot merged commit d88f8f0 into OCA:16.0 Jun 2, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 2, 2023

ljsalvatierra-factorlibre deleted the 16.0-mig-account_invoice_margin branch June 5, 2023 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_invoice_margin: Migration to v16 #163

[16.0][MIG] account_invoice_margin: Migration to v16 #163

ljsalvatierra-factorlibre commented Mar 1, 2023

legalsylvain commented Mar 1, 2023

ljsalvatierra-factorlibre commented Mar 1, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

pedrobaeza commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

legalsylvain commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

legalsylvain commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 10, 2023

legalsylvain left a comment

legalsylvain Mar 10, 2023

ljsalvatierra-factorlibre Mar 10, 2023

legalsylvain Mar 10, 2023

Yadier-Tecnativa commented Apr 27, 2023 •

edited

Loading

pedrobaeza commented Apr 27, 2023

gerard-vacas commented May 23, 2023

rafaelbn commented May 25, 2023

ljsalvatierra-factorlibre commented May 26, 2023

Gelo-fl left a comment

OCA-git-bot commented Jun 2, 2023

RodrigoBM commented Jun 2, 2023

pedrobaeza commented Jun 2, 2023

OCA-git-bot commented Jun 2, 2023

OCA-git-bot commented Jun 2, 2023

sergio-teruel commented Jun 5, 2023

	for line in invoice._get_margin_applicable_lines():
	for line in invoice.line_ids.filtered(lambda x: x.is_margin_applicable):

[16.0][MIG] account_invoice_margin: Migration to v16 #163

[16.0][MIG] account_invoice_margin: Migration to v16 #163

Conversation

ljsalvatierra-factorlibre commented Mar 1, 2023

legalsylvain commented Mar 1, 2023

ljsalvatierra-factorlibre commented Mar 1, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

pedrobaeza commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

legalsylvain commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

legalsylvain commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 8, 2023

ljsalvatierra-factorlibre commented Mar 10, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

legalsylvain Mar 10, 2023

Choose a reason for hiding this comment

ljsalvatierra-factorlibre Mar 10, 2023

Choose a reason for hiding this comment

legalsylvain Mar 10, 2023

Choose a reason for hiding this comment

Yadier-Tecnativa commented Apr 27, 2023 • edited Loading

pedrobaeza commented Apr 27, 2023

gerard-vacas commented May 23, 2023

rafaelbn commented May 25, 2023

ljsalvatierra-factorlibre commented May 26, 2023

Gelo-fl left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jun 2, 2023

RodrigoBM commented Jun 2, 2023

pedrobaeza commented Jun 2, 2023

OCA-git-bot commented Jun 2, 2023

OCA-git-bot commented Jun 2, 2023

sergio-teruel commented Jun 5, 2023

Yadier-Tecnativa commented Apr 27, 2023 •

edited

Loading