Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] product_standard_margin: Migration to 16.0 #172

Merged
merged 57 commits into from
Jun 21, 2023

Conversation

amarcosg
Copy link

@amarcosg amarcosg commented Jun 5, 2023

No description provided.

jgrandguillaume and others added 30 commits June 5, 2023 10:17
…re on:

      - Margin modules
      - picking dispatch (better warehouse handling))
      - grouping PO
      - Filter on stock delivers from sales
(lp:c2c-addons/6.1  rev 28.3.22)
          [DOC] Some typo and docstring
          [IMP] Warning message if no move available for dispatch creation
          [IMP] Start adding relation between picking and dispatch
(lp:c2c-addons/6.1  rev 28.6.4)
…hat still need strong testing

(lp:c2c-addons/6.1  rev 28.6.24)
… analysis to add margin

          [IMP] Add tax include/exlude support on margin computation
          [FIX] Little Typo and fixes after tests
(lp:c2c-addons/6.1  rev 28.6.25)
…racted code to new modules

          extracted the bits about the computation of product cost with BoM from sale_markup to product_cost_incl_bom
(lp:c2c-addons/6.1  rev 40.1.13)
  - Margin modules
  - picking dispatch (better warehouse handling))
  - grouping PO
  - Filter on stock delivers from sales
(lp:c2c-addons/6.1  rev 69)
…t make standard_margin and standard_margin_rate stored fields;
[FIX] margin precision;
[REF] new description in readme file;
[ADD] new 'field list_price_vat_excl';
@amarcosg amarcosg mentioned this pull request Jun 5, 2023
10 tasks
@amarcosg amarcosg changed the title [MIG] product_standard_margin: Migration to 16.0 [16.0][MIG] product_standard_margin: Migration to 16.0 Jun 5, 2023
@rafaelbn
Copy link
Member

/ocabot migration product_standard_margin

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 13, 2023
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff review. Thanks !

digits=dp.get_precision("Product Price"),
help="Markup rate is [ Theorical Margin / sale price (Wo Tax) ] "
digits="Product Price",
help="Margin rate is [ Theorical Margin / sale price (Wo Tax) ] "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

Copy link

@hugo-cordoba hugo-cordoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hugo-cordoba
Copy link

Hi @pedrobaeza, can you check this?

Regardss!!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-172-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 57bc926 into OCA:16.0 Jun 21, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2868e03. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.