-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] product_standard_margin: Migration to 16.0 #172
[16.0][MIG] product_standard_margin: Migration to 16.0 #172
Conversation
…re on: - Margin modules - picking dispatch (better warehouse handling)) - grouping PO - Filter on stock delivers from sales (lp:c2c-addons/6.1 rev 28.3.22)
[DOC] Some typo and docstring [IMP] Warning message if no move available for dispatch creation [IMP] Start adding relation between picking and dispatch (lp:c2c-addons/6.1 rev 28.6.4)
…hat still need strong testing (lp:c2c-addons/6.1 rev 28.6.24)
… analysis to add margin [IMP] Add tax include/exlude support on margin computation [FIX] Little Typo and fixes after tests (lp:c2c-addons/6.1 rev 28.6.25)
…racted code to new modules extracted the bits about the computation of product cost with BoM from sale_markup to product_cost_incl_bom (lp:c2c-addons/6.1 rev 40.1.13)
- Margin modules - picking dispatch (better warehouse handling)) - grouping PO - Filter on stock delivers from sales (lp:c2c-addons/6.1 rev 69)
… This will happend in the next coming month.
…t make standard_margin and standard_margin_rate stored fields;
[FIX] margin precision; [REF] new description in readme file; [ADD] new 'field list_price_vat_excl';
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-14.0/margin-analysis-14.0-product_standard_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-14-0/margin-analysis-14-0-product_standard_margin/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-15.0/margin-analysis-15.0-product_standard_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-15-0/margin-analysis-15-0-product_standard_margin/
/ocabot migration product_standard_margin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff review. Thanks !
digits=dp.get_precision("Product Price"), | ||
help="Markup rate is [ Theorical Margin / sale price (Wo Tax) ] " | ||
digits="Product Price", | ||
help="Margin rate is [ Theorical Margin / sale price (Wo Tax) ] " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review)
This PR has the |
Hi @pedrobaeza, can you check this? Regardss!! |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 2868e03. Thanks a lot for contributing to OCA. ❤️ |
No description provided.