[16.0][MIG] product_replenishment_cost: Migration to 16.0 (from 12.0) #174

amarcosg · 2023-06-05T11:01:34Z

No description provided.

- move product_get_cost_field from unported folder to root folder; rename module; [PORT] various changes realized in v7 branch; specially 7f3f629 [REF] OCA convention about folders; [PORT] V8 api; [ADD] demo data; [FIX] set replenishment_cost as a stored field;

Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-12.0/margin-analysis-12.0-product_replenishment_cost Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-12-0/margin-analysis-12-0-product_replenishment_cost/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-12.0/margin-analysis-12.0-product_replenishment_cost Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-12-0/margin-analysis-12-0-product_replenishment_cost/

Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-12.0/margin-analysis-12.0-product_replenishment_cost Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-12-0/margin-analysis-12-0-product_replenishment_cost/pt/

Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-12.0/margin-analysis-12.0-product_replenishment_cost Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-12-0/margin-analysis-12-0-product_replenishment_cost/it/

legalsylvain

Hi. Diff review ok. Thanks for porting this module.
however, I'm asking about the usefulness of this module. Why do you need this module ? is it related to the module product_cost_incl_bom ? or other use case(s) ?

amarcosg · 2023-06-05T13:39:22Z

Hi @legalsylvain first thanks for the review.

Ill give you and insight of the use we give it comparing it with the cost price. The cost price is the cost assigned for each product in the warehouse, the replenishment cost is the cost it would cost to buy a new product. They are different costs because the cost price depends on your valuation method and the operations you have performed while the replacement cost is determined by the current market conditions.

The price of the product in the supplier's catalog is €15/piece. Therefore, if I want to buy a new unit, my replenishment cost would be €15. But if my stock comes from having bought it in a special offer that allowed me to buy it for €10, then my cost price is €10/piece.

We use it mainly by not taking into account the cost price but calculating the replenishment cost from the suppliers' rates.

We are going to implement this logic in a module for v16, I have no problem in proposing it for this repository if as a community we see that it is useful.

legalsylvain · 2023-06-05T15:18:50Z

Hi @amarcosg.
First, thanks for your explanation.

I think that your comment could be a part of the DESCRIPTION.rst file, to explain better the objective of this module. (the use case with prices, for exemple).
side question (not related to the current PR) : how do you update the standard_price, in your process ? I mean, if you buy 5 products at 8€ and 5 products to 12€, how do you update the standard price, to put 10€ ?

amarcosg · 2023-06-06T10:30:58Z

@legalsylvain Ill update the DESCRIPTION.rst to made it more clear.

Regarding the second point, it depends on the customer. Some use the average price, others as in the example I have given you would correspond to the last purchase price, which is another option we have.

In that case the cost price would correspond to the last price at which I have purchased but the replenishment cost would depend on the suppliers rates of the product.

legalsylvain · 2023-06-06T12:46:00Z

Thanks for the explanation !

rafaelbn · 2023-06-13T23:18:20Z

/ocabot migration product_replenishment_cost

rafaelbn · 2023-06-13T23:22:37Z

Thank you!

Which is the differences with product supplierinfo?

amarcosg · 2023-06-22T15:34:04Z

Hi @rafaelbn thank you.

In the example i give here #174 (comment) i only take into account the calculation with the supplierinfo, but it doesnt have to be like that always. It may be equal to our best supplierinfo in some cases (we mostly do it that way), but it may not. For example with bill of materials or some products we invoice at product reception an we use that price.

It allows us some flexibility and above all it gives us insight into the costs of our inventory.

hugo-cordoba

LGTM!

hugo-cordoba · 2023-07-20T10:35:43Z

Hi @legalsylvain, I saw that you commented on the PR, do you see the final result well, can you approve it and merge it?

thanks in advance, best regards!

hugo-cordoba · 2023-07-25T08:21:18Z

Hi, sorry for the insistence @legalsylvain, can you take a look at it?

legalsylvain

thanks !

hugo-cordoba · 2023-07-25T09:45:07Z

Hi @pedrobaeza!

Could you take a look this PR and merge please?

Thankss! Best regards!

pedrobaeza · 2023-07-25T11:53:20Z

/ocabot merge nobump

OCA-git-bot · 2023-07-25T11:53:38Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-174-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-07-25T11:59:44Z

Congratulations, your PR was merged at 322c17d. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 25 commits June 5, 2023 12:20

[UPD] prefix versions with 8.0

9489bd8

[MIG] Make modules uninstallable

946998d

[MIG] Rename manifest files

a551644

remove obsolete .pot files [ci skip]

add3d9e

migrate product_replenishment_cost to v9

a194db2

[ADD] icon.png

87fe374

[MIG] product_replenishment_cost: Migration to 10.0

425ae92

[UPD] Update product_replenishment_cost.pot

69d94e3

[UPD] README.rst

52858f7

[PORT][12.0] product_replenishment_cost

115aacd

[UPD] Update product_replenishment_cost.pot

6249e8b

[UPD] README.rst

5a9f944

Added translation using Weblate (Chinese (Simplified))

86a8957

Added translation using Weblate (Portuguese (Brazil))

0c934b0

Added translation using Weblate (Portuguese)

ecb541b

Added translation using Weblate (Italian)

b1befe5

[REF] apply pre-commit fixes

55bd0a2

product_replenishment_cost 12.0.1.0.1

39977b1

[IMP] product_replenishment_cost: pre-commit stuff

4075ec6

[MIG] product_replenishment_cost: Migration to 16.0

05fcaaa

amarcosg mentioned this pull request Jun 5, 2023

Migration to version 16.0 #142

Open

10 tasks

legalsylvain reviewed Jun 5, 2023

View reviewed changes

[UPD] DESCRIPTION.rst

3a8911e

rafaelbn added the needs review label Jun 13, 2023

OCA-git-bot added this to the 16.0 milestone Jun 13, 2023

hugo-cordoba approved these changes Jul 20, 2023

View reviewed changes

legalsylvain approved these changes Jul 25, 2023

View reviewed changes

OCA-git-bot added the approved label Jul 25, 2023

OCA-git-bot added the bot is merging ⏳ label Jul 25, 2023

OCA-git-bot merged commit 56ee055 into OCA:16.0 Jul 25, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] product_replenishment_cost: Migration to 16.0 (from 12.0) #174

[16.0][MIG] product_replenishment_cost: Migration to 16.0 (from 12.0) #174

amarcosg commented Jun 5, 2023

legalsylvain left a comment

amarcosg commented Jun 5, 2023 •

edited

Loading

legalsylvain commented Jun 5, 2023

amarcosg commented Jun 6, 2023

legalsylvain commented Jun 6, 2023

rafaelbn commented Jun 13, 2023

rafaelbn commented Jun 13, 2023

amarcosg commented Jun 22, 2023

hugo-cordoba left a comment

hugo-cordoba commented Jul 20, 2023 •

edited

Loading

hugo-cordoba commented Jul 25, 2023

legalsylvain left a comment

hugo-cordoba commented Jul 25, 2023

pedrobaeza commented Jul 25, 2023

OCA-git-bot commented Jul 25, 2023

OCA-git-bot commented Jul 25, 2023

[16.0][MIG] product_replenishment_cost: Migration to 16.0 (from 12.0) #174

[16.0][MIG] product_replenishment_cost: Migration to 16.0 (from 12.0) #174

Conversation

amarcosg commented Jun 5, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

amarcosg commented Jun 5, 2023 • edited Loading

legalsylvain commented Jun 5, 2023

amarcosg commented Jun 6, 2023

legalsylvain commented Jun 6, 2023

rafaelbn commented Jun 13, 2023

rafaelbn commented Jun 13, 2023

amarcosg commented Jun 22, 2023

hugo-cordoba left a comment

Choose a reason for hiding this comment

hugo-cordoba commented Jul 20, 2023 • edited Loading

hugo-cordoba commented Jul 25, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

hugo-cordoba commented Jul 25, 2023

pedrobaeza commented Jul 25, 2023

OCA-git-bot commented Jul 25, 2023

OCA-git-bot commented Jul 25, 2023

amarcosg commented Jun 5, 2023 •

edited

Loading

hugo-cordoba commented Jul 20, 2023 •

edited

Loading