[13.0] multi company improvements #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbidoul! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the |
|
Looks like this bot message about maintainers is not working as exepected, as I am a maintainer... |
sbidoul
force-pushed
the
ForgeFlow-13.0-mis_builder-fix-multicompany
branch
from
3b009a4
to
3175dbf
Compare
This was referenced Aug 13, 2021
Closed
- The mis.report.instance should allow to define as many companies as the user is allowed to operate on when logged. - The company is only a required field if the flag 'multi_company' is not set.
…tor and fix tests
It is the intersection of selected companies on the report and env.companies (which apply as multi company record rules) Hide the company_id field in multi_company reports.
sbidoul
force-pushed
the
ForgeFlow-13.0-mis_builder-fix-multicompany
branch
from
3175dbf
to
d039e4e
Compare
|
@MiquelRForgeFlow @JordiBForgeFlow have you had a chance to look at this followup to your previous PR ? |
LoisRForgeFlow
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #327 with the the few improvements I suggested in review comments.
@MiquelRForgeFlow @JordiBForgeFlow let me know what you think.
closes #379
closes #327