[FIX] convert_html_fragment: Don't wrap full XMLs #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the HTML string to convert is a fully XML compliant file including the header `<?xml version="...?>`, the wrapping process is breaking the final result, as the expected XML syntax doesn't include `?` in the middle and lxml returns a weird result `<?xml version="...??>` with 2 interrogations. With this commit, we are not wrapping if we detect the XML header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the HTML string to convert is a fully XML compliant file including the header
<?xml version="...?>, the wrapping process is breaking the final result, as the expected XML syntax doesn't include?in the middle and lxml returns a weird result<?xml version="...??>with 2 interrogations.With this commit, we are not wrapping if we detect the XML header.
Fine-tune of #349
@Tecnativa