[FIX] core.exceptions.UserError --> Warning #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legalsylvain
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Hi. openupgradelib has to be used with all version of odoo. Not only the last one.
for that reason, this patch is not valid.
See red CI, in openerp 6.1 context
AttributeError: 'module' object has no attribute 'UserError'
https://app.travis-ci.com/github/OCA/openupgradelib/builds/267217636#L821
|
You have to do a conditional import depending on Odoo version. |
The deprecated warning was removed on 17 (odoo/odoo@d200dcf)
jjscarafia
force-pushed
the
master-fix-for-17
branch
from
2f36577 to
ecd3200
Compare
|
done @pedrobaeza @legalsylvain |
pedrobaeza
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated warning was removed on 17 (odoo/odoo@d200dcf)