[FIX][IMP] _convert_field_bootstrap_4to5_orm: translatable fields #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The improvement made in 40741d9 couldn't deal with json columns of translatable fields. In any case a more simpler approach can be took if we simply discard all the records which don't even have a `class` attribute in their html code, meaning that we don't need to make the Bootstrap migration at all. TT46020
1 task
MiquelRForgeFlow
approved these changes
Jun 11, 2024
|
We should go fast with this. |
pedrobaeza
approved these changes
Jun 11, 2024
pedrobaeza
deleted the
fix-convert_field_bootstrap_4to5-not_html_empty_where_clause
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvement made in 40741d9 couldn't deal with json columns of translatable fields.
In any case a more simpler approach can be took if we simply discard all the records which don't even have a
classattribute in their html code, meaning that we don't need to make the Bootstrap migration at all.cc @Tecnativa TT46020