[IMP]convert_field_to_html: manage translated fields #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
approved these changes
Oct 1, 2024
|
@pedrobaeza @legalsylvain maybe this interest you. It replace the following PR : #358 |
pedrobaeza
reviewed
Oct 1, 2024
openupgradelib/openupgrade.py
Outdated
| """ | ||
| Convert field value to HTML value. | ||
|
|
||
| .. versionadded:: 7.0 | ||
| """ | ||
|
|
There was a problem hiding this comment.
Don't add empty lines inside a method, please (and the same for the next one)
clementelabore
force-pushed
the
pr-convert-translated-field-to-html
branch
from
8c378b9 to
8a5d4be
Compare
|
What are the next step to merge and create a new release usable with pip ? |
clementelabore
force-pushed
the
pr-convert-translated-field-to-html
branch
from
8a5d4be to
0206473
Compare
clementelabore
force-pushed
the
pr-convert-translated-field-to-html
branch
from
0206473 to
b7c7ec9
Compare
pedrobaeza
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve convert_field_to_html method: added translate=False parameter to handle translatable fields