Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP]openupgrade: disable_invalid_filters #391

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

leemannd
Copy link
Contributor

@leemannd leemannd commented Nov 1, 2024

Trying to solve

After a migration it was not possible to open the settings submenu: "User-defined filters".
This was due to invalid user filters.

Cause

The current script is not testing action_id. Some user filters contained deleted ir.actions.actions.
It was then failing when performing the web_read.

In this PR I'm adding a test related to the inhexistance of the related ir.actions.actions.

@leemannd leemannd force-pushed the imp_disable_invalid_filters branch from d661057 to 3367485 Compare November 1, 2024 15:09
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I see the field action_id has been around since 8.0, as has the exists method so this should be safe.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra check

@pedrobaeza pedrobaeza merged commit e512ee6 into OCA:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants