Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] purchase_request_operating_unit #348

Merged

Conversation

Saran440
Copy link
Member

Standard Migration

depends on

@Saran440 Saran440 force-pushed the 14.0-mig-purchase_request_operating_unit branch from ba68243 to 2a5b7e9 Compare December 10, 2020 09:59
@PrapassornS PrapassornS force-pushed the 14.0-mig-purchase_request_operating_unit branch from 5cd0dab to e8caedb Compare March 18, 2021 08:56
@newtratip
Copy link
Member

CI is red, please check.

@kittiu
Copy link
Member

kittiu commented Jun 3, 2021

@Saran440 can you check travis / rebase.

@patrickrwilson
Copy link
Contributor

@Saran440 I noticed the depend module was merged so I restarted Travis/Runbot and things look good there. I think all you need to do is squash the [UPD] and Translation commits to clean those up and then I will review.

@Saran440 Saran440 force-pushed the 14.0-mig-purchase_request_operating_unit branch from 8d7bb3f to 59ef569 Compare June 5, 2021 13:23
@Saran440
Copy link
Member Author

Saran440 commented Jun 5, 2021

@kittiu @patrickrwilson Sorry for late, I fixed and rebase already.
please, could you review?

Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few cosmetic requested changes but no blockers, LGTM.

@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="utf-8" ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't needed anymore since v11. Not a blocker.

@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="utf-8" ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't needed anymore since v11. Not a blocker.

@kittiu
Copy link
Member

kittiu commented Jun 23, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-348-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit ef41fd4 into OCA:14.0 Jun 23, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 68aef37. Thanks a lot for contributing to OCA. ❤️

@newtratip newtratip deleted the 14.0-mig-purchase_request_operating_unit branch June 24, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants