Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] [MIG] sales_team_operating_unit #441

Merged
merged 24 commits into from
Jan 18, 2022
Merged

[15.0] [MIG] sales_team_operating_unit #441

merged 24 commits into from
Jan 18, 2022

Conversation

Rajan-SCS
Copy link
Contributor

No description provided.

@Rajan-SCS Rajan-SCS mentioned this pull request Jan 12, 2022
Closed
30 tasks
@AaronHForgeFlow
Copy link
Contributor

/ocabot migration sales_team_operating_unit

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 12, 2022
@Rajan-SCS Rajan-SCS force-pushed the 15_mig_sales_team_operating_unit branch from 2e9943a to b2ed561 Compare January 12, 2022 11:35
alan196
alan196 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan196
Copy link
Contributor

alan196 commented Jan 12, 2022

Just fix pre-commit

@Rajan-SCS Rajan-SCS force-pushed the 15_mig_sales_team_operating_unit branch from b2ed561 to f2d4251 Compare January 13, 2022 04:53
@Rajan-SCS
Copy link
Contributor Author

@alan196 Fixed the pre-commit

@Rajan-SCS
Copy link
Contributor Author

@AaronHForgeFlow @nikul-serpentcs can you please take a look?

AaronHForgeFlow
AaronHForgeFlow previously approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@AaronHForgeFlow
Copy link
Contributor

What I dont understand is why the commit messages have been amended:
image

@AaronHForgeFlow AaronHForgeFlow dismissed their stale review January 13, 2022 10:52

Commit messages are reworded incorrectly

@Rajan-SCS Rajan-SCS closed this Jan 18, 2022
@Rajan-SCS Rajan-SCS force-pushed the 15_mig_sales_team_operating_unit branch from f2d4251 to aa36f70 Compare January 18, 2022 09:47
@Rajan-SCS Rajan-SCS reopened this Jan 18, 2022
@Rajan-SCS
Copy link
Contributor Author

@AaronHForgeFlow could you please check the PR

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good :)

nikul-serpentcs
nikul-serpentcs approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

@AaronHForgeFlow ready to merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-441-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6b8f00e into OCA:15.0 Jan 18, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ab2376c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@alan196 alan196 alan196 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.