Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_asset_operating_unit #555

Merged
merged 9 commits into from
Mar 10, 2023
Merged

[15.0][MIG] account_asset_operating_unit #555

merged 9 commits into from
Mar 10, 2023

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Feb 1, 2023 •
edited
Loading

  • Add test script
  • Add group by operating unit

@Saran440 Saran440 mentioned this pull request Feb 1, 2023
Closed
1 task
@Saran440 Saran440 mentioned this pull request Feb 17, 2023
Merged
2 tasks
AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

/ocabot migration account_asset_operating_unit

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 10, 2023
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-555-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 10, 2023
Closed
30 tasks
@OCA-git-bot OCA-git-bot merged commit 6b29a98 into OCA:15.0 Mar 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f06aab7. Thanks a lot for contributing to OCA. ❤️

@Saran440
Copy link
Member Author

@AaronHForgeFlow Hello, May I ask you about filter OU.

Asset1 - OU-A
Asset2 - No OU

Options

  1. Filter OU-A --> it will generate all OU-A and asset don't have operating unit (Asset1 and Asset2)
  2. Filter OU-A --> it will generate all OU-A only (Asset1). - [14.0][FIX] account_asset_operating_unit: fix reporting by OU #499

What is option that make sense for you?

@AaronHForgeFlow
Copy link
Contributor

Typically, for access meaning if I have access to OU-A then I would see all assets OU-A and assets without OU.

However, for the purpose of filtering I think it makes more sense the second option. So yes, probably that PR needs to be forward ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Saran440 @OCA-git-bot @AaronHForgeFlow @ps-tubtim @oca-travis