Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] analytic_operating_unit: Migration to 16.0 #586

Merged
merged 18 commits into from
Jun 5, 2023
Merged

[16.0][MIG] analytic_operating_unit: Migration to 16.0 #586

merged 18 commits into from
Jun 5, 2023

Conversation

BT-aleonard
Copy link
Contributor

No description provided.

@BT-aleonard BT-aleonard changed the title [16.0][MIG] analytic operating unit: Migration to 16.0 [16.0][MIG] analytic_operating_unit: Migration to 16.0 May 11, 2023
@BT-aleonard
Copy link
Contributor Author

/ocabot migration analytic_operating_unit

@OCA-git-bot
Copy link
Contributor

Sorry @BT-aleonard you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@BT-aleonard BT-aleonard mentioned this pull request May 11, 2023
Open
10 tasks
@BT-aleonard BT-aleonard force-pushed the 16.0-mig-analytic_operating_unit branch from 4a679f8 to 006d31b Compare May 11, 2023 10:28
@AaronHForgeFlow
Copy link
Contributor

/ocabot migration analytic_operating_unit

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 11, 2023
alan196 and others added 8 commits May 11, 2023 12:42
@alan196 @BT-aleonard
Translated using Weblate (Spanish (Mexico))
9afe3e6 
Currently translated at 100.0% (2 of 2 strings)

Translation: operating-unit-13.0/operating-unit-13.0-analytic_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-analytic_operating_unit/es_MX/
@MiquelRForgeFlow @BT-aleonard
[UPD] Eficent -> ForgeFlow
21d8141
@alan196 @BT-aleonard
[IMP] analytic_operating_unit: black, isort, prettier
c461dc0
@alan196 @BT-aleonard
[MIG] analytic_operating_unit: Migration to 14.0
7b0aac3
@alan196 @BT-aleonard
[MIG] analytic_operating_unit: Migration to 15.0
61ceb6a
@ibuioli @BT-aleonard
Translated using Weblate (Spanish (Argentina))
49cbcde 
Currently translated at 100.0% (2 of 2 strings)

Translation: operating-unit-15.0/operating-unit-15.0-analytic_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-analytic_operating_unit/es_AR/
@Saran440 @BT-aleonard
[FIX] analytic_operating_unit: Error when search operating units in a…
cfe423b 
…nalytic account
@BT-aleonard
[IMP] analytic_operating_unit: pre-commit stuff
7b3eb61
@BT-aleonard BT-aleonard force-pushed the 16.0-mig-analytic_operating_unit branch from 006d31b to d6c41ae Compare May 11, 2023 10:42
BT-anieto
BT-anieto approved these changes May 11, 2023
View reviewed changes
Copy link

@BT-anieto BT-anieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot!

BT-rmartin
BT-rmartin approved these changes May 12, 2023
View reviewed changes
Copy link

@BT-rmartin BT-rmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with the migration.
By the way I see no unit tests in the module, that could be added once it's merged as an improvement

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-aleonard
Copy link
Contributor Author

Hi @AaronHForgeFlow,
Can you take a look to this PR, please?
Thanks.

AaronHForgeFlow
AaronHForgeFlow reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I had to modify the form view in order to edit the operating units in runbot.

analytic_operating_unit/views/analytic_account_view.xml Outdated Show resolved Hide resolved
@BT-aleonard BT-aleonard force-pushed the 16.0-mig-analytic_operating_unit branch from d6c41ae to 18580ff Compare June 5, 2023 15:19
@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-586-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 589b3d2 into OCA:16.0 Jun 5, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 38d8e43. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-anieto BT-anieto BT-anieto approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@BT-rmartin BT-rmartin BT-rmartin approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.