[16.0] Migration of sales_team_operating unit #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] sales_team_operating_unit
- Remove encodings - Bump Version - Fix form view to place under company_id - Test - Fix security rules
|
@EduardoJarsa @YahairaCVJarsa could you help me to review this PR 🙏 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
EduardoJarsa
approved these changes
Aug 2, 2023
YahairaCVJarsa
approved these changes
Aug 2, 2023
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
YahairaCVJarsa
approved these changes
Aug 2, 2023
|
Congratulations, your PR was merged at c71efc3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #592
I have removed the domain of company_id in operating unit, this is defined by the ir.rule of module operating_unit, so it's not needed.
This raises errors as in V16 the field company_id belongs to a group, and give error on installation.