Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX]pos_partner_firstname: Create and Update partner #1122

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[16.0][FIX]pos_partner_firstname: Create and Update partner #1122

merged 1 commit into from
Jan 15, 2024

Conversation

DorianMAG
Copy link
Contributor

  • Add useState and add missed fields
  • Update saveChanges() method
  • Update template
  • Remove jquery code

@OCA-git-bot
Copy link
Contributor

Hi @robyf70,
some modules you are maintaining are being modified, check this out!

@chienandalu chienandalu added this to the 16.0 milestone Jan 8, 2024
@DorianMAG DorianMAG mentioned this pull request Jan 8, 2024
Closed
@legalsylvain legalsylvain mentioned this pull request Jan 8, 2024
Open
chienandalu
chienandalu requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In the formal side:

  • Don't put versions on the commit messages
  • Squash your commits into a single one

@DorianMAG DorianMAG force-pushed the 16.0_FIX_pos_partner_firstname branch from cb2065e to 0035399 Compare January 8, 2024 14:47
@DorianMAG
Copy link
Contributor Author

Looks good. In the formal side:

* Don't put versions on the commit messages

* Squash your commits into a single one

It' s done
Regards

JulienMartinez
JulienMartinez approved these changes Jan 8, 2024
View reviewed changes
Copy link

@JulienMartinez JulienMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DorianMAG DorianMAG changed the title [16.0][FIX]pos_partner_firstname [16.0][FIX]pos_partner_firstname: Create and Update partner Jan 8, 2024
FrancoMaxime
FrancoMaxime approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review

robyf70
robyf70 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flotho flotho mentioned this pull request Jan 10, 2024
Merged
etobella
etobella approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEsted functionally

@ivantodorovich
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1122-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 15, 2024
@OCA-git-bot
Merge PR #1122 into 16.0
837ace6 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1122-by-ivantodorovich-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@DorianMAG DorianMAG mentioned this pull request Jan 15, 2024
Closed
@ivantodorovich
Copy link
Contributor

retry
/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1122-by-ivantodorovich-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5c4a16a into OCA:16.0 Jan 15, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 58b7001. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyf70 robyf70 robyf70 approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

@etobella etobella etobella approved these changes

@JulienMartinez JulienMartinez JulienMartinez approved these changes

@CLEBORGNEAPIK CLEBORGNEAPIK CLEBORGNEAPIK approved these changes

@chienandalu chienandalu Awaiting requested review from chienandalu

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@DorianMAG @OCA-git-bot @ivantodorovich @robyf70 @chienandalu @FrancoMaxime @etobella @JulienMartinez @CLEBORGNEAPIK