-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] mig pos_margin_account_invoice_margin #1128
[16.0] mig pos_margin_account_invoice_margin #1128
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: pos-12.0/pos-12.0-pos_margin_account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin_account_invoice_margin/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_margin_account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_margin_account_invoice_margin/
/ocabot migration pos_margin_account_invoice_margin CC : @quentinDupont |
a3fa5a0
to
29845a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand this glue module :-D
Function _action_create_invoice_line
doesn't seems to exists anymore
Tested without this module and invoices created from POS are well handle for margin
Hum.... very nice catch @quentinDupont ! maybe It means that the code is useless ;-) I'll take a look more deeply in the next days. thanks for your review. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
… anymore. OCA/account_invoice_margin works out of the box with Odoo/point_of_sale. See : OCA/pos#1128
Indeed. Tested with point_of_sale and OCA/account_invoice_margin installed. The invoice created from PoS has correct margin and purchase_price, without any extra module. OCA/OpenUpgrade#4450 to be reviewed. Thanks @quentinDupont ! |
This module is a glue module between two OCA modules,
pos_margin
(same repository) andaccount_invoice_margin
(OCA/margin-analysis).
With this module, invoices created from point of sale have correct margin.
Note
When installing this module, the margin will be computed from invoices that has been generated from point of sale.