Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] mig pos_margin_account_invoice_margin #1128

Closed

Conversation

legalsylvain
Copy link
Contributor

This module is a glue module between two OCA modules, pos_margin (same repository) and account_invoice_margin
(OCA/margin-analysis).

With this module, invoices created from point of sale have correct margin.

Note

When installing this module, the margin will be computed from invoices that has been generated from point of sale.

@legalsylvain
Copy link
Contributor Author

/ocabot migration pos_margin_account_invoice_margin

CC : @quentinDupont
original reviewers : @chienandalu, @ivantodorovich (#783)

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 13, 2024
37 tasks
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_margin_account_invoice_margin branch from a3fa5a0 to 29845a1 Compare January 15, 2024 10:16
Copy link

@quentinDupont quentinDupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand this glue module :-D

Function _action_create_invoice_line doesn't seems to exists anymore
Tested without this module and invoices created from POS are well handle for margin

@legalsylvain
Copy link
Contributor Author

Hum.... very nice catch @quentinDupont !
Indeed, the test of the module is green BUT, the code of this module is not executed...

image

maybe It means that the code is useless ;-) I'll take a look more deeply in the next days.

thanks for your review.

Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
legalsylvain added a commit to grap/OpenUpgrade that referenced this pull request Jun 4, 2024
… anymore. OCA/account_invoice_margin works out of the box with Odoo/point_of_sale.

See : OCA/pos#1128
@legalsylvain
Copy link
Contributor Author

Tested without this module and invoices created from POS are well handle for margin

Indeed. Tested with point_of_sale and OCA/account_invoice_margin installed. The invoice created from PoS has correct margin and purchase_price, without any extra module.

OCA/OpenUpgrade#4450 to be reviewed.

Thanks @quentinDupont !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants