Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] pos_event_sale: Migration to 16.0 #1205

Draft
wants to merge 51 commits into
base: 16.0
Choose a base branch
from

Conversation

maq-adhoc
Copy link

No description provided.

@maq-adhoc
Copy link
Author

@ivantodorovich , continue the pr of @BT-dmoreno (#1022) Here.

@maq-adhoc maq-adhoc force-pushed the 16.0-t-40124-maq branch 3 times, most recently from e9d3004 to 28ec285 Compare June 18, 2024 12:36
@maq-adhoc maq-adhoc changed the title [16.0] [MIG] pos_product_template: Migration to 16.0 [16.0] [MIG] pos_event_sale: Migration to 16.0 Jun 18, 2024
@ivantodorovich
Copy link
Contributor

Thanks @maq-adhoc !

CI is still broken, though.
Feel free to ping me when it's green and I'll drop a review :)

@maq-adhoc
Copy link
Author

@ivantodorovich , this week I want to leave all the tests ok. When it's ready I'll let you know

@legalsylvain
Copy link
Contributor

/ocabot migration pos_event_sale

@legalsylvain legalsylvain marked this pull request as draft July 2, 2024 09:21
@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 2, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#849) has not been updated to reference the current pull request because a previous pull request (#1022) is not closed.
Perhaps you should check that there is no duplicate work.
CC @BT-dmoreno

@maq-adhoc maq-adhoc force-pushed the 16.0-t-40124-maq branch 2 times, most recently from 2325ccf to de173b9 Compare August 15, 2024 19:13
@maq-adhoc maq-adhoc force-pushed the 16.0-t-40124-maq branch 2 times, most recently from c1b3a42 to 880624e Compare August 20, 2024 18:45
@maq-adhoc maq-adhoc force-pushed the 16.0-t-40124-maq branch 2 times, most recently from 7e8997b to d6a1b82 Compare September 5, 2024 19:52
@maq-adhoc maq-adhoc force-pushed the 16.0-t-40124-maq branch 2 times, most recently from 87fed76 to 843c094 Compare November 1, 2024 11:09
ivantodorovich and others added 10 commits November 1, 2024 19:49
By default, the longPressDelay is 1000ms which is not intuitive
and makes it pretty much unusable in touchscreen devices.

In this case, it makes no sense to have a delay for selecting dates.
By setting it to 0 we're effectively disabling the pressDelay, and
the user experience is much better.
* Print event.registration receipts.
* Refunding a pos.order will cancel the event registrations.
* Support pricelists.
* Refactored code for better overrideability.
Camille0907 and others added 29 commits November 1, 2024 19:49
… pos_order_line before installation

This helps to avoid a Memory Error when installing this module on an instance with a big amount of existing pos_order_line
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
When paying a `pos.order`, confirm only the `event.registration` that are
in draft state. Don't attempt to confirm the ones that are already confirmed,
nor the ones that might be cancelled.
If we cancel a `pos.order`, we should cancel the related `event.registration`(s)
However, if the `event.registration` is already done, we should not cancel it
as it would be already too late to do so.
Registrations created from the PoS are not to be confirmed automatically.
We confirm them when the `pos.order` is paid, but they are to remain in `draft`
until then.
In the PoS, if the order is not paid, then it's not confirmed.
If it's not confirmed, then we might as well ignore it. We shouldn't
cancel any existing registrations until then.
Negated lines are particularly useful with PoS modules that disable the removal
of pos orderlines through the use of ``disallowLineQuantityChange``.

This is the case of `l10n_fr_pos_cert` module, for example. But there are other
core modules doing it, too.

In this case, added order lines can't be removed. Instead, the cashier is
encouraged to add a negative to 'cancel' the original one.

e.g.:

Adds a line with 10 tickets.
Then, adds a line with -10 tickets.

This should be almost the same as removing the first line: no actual
registration should be confirmed in the end, as we're reverting this sale.
Moved some ORM tests to `tests_backend`, that will execute faster than tours.
Added unit tests to cover more backend scenarios.
EventEventTicket inherits from EventTypeTicket, so we don't need to duplicate the field declaration, if it is the same in both module. This ease overriding, as we need to override only one model, if we expect the same behavior in both.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
Currently translated at 100.0% (73 of 73 strings)

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants