Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [mig] pos_default_partner #627

Merged
merged 14 commits into from
Jun 7, 2021
Merged

[14.0] [mig] pos_default_partner #627

merged 14 commits into from
Jun 7, 2021

Conversation

fshah-initos
Copy link
Contributor

No description provided.

bealdav and others added 14 commits April 19, 2021 16:18
@bealdav @fshah-initos
ADD module pos_default_partner
9e2f999
@fshah-initos
[IMP] pos_default_partner add continuation
bd7312a
@oca-travis @fshah-initos
[UPD] Update pos_default_partner.pot
46389b6
@OCA-git-bot @fshah-initos
[ADD] icon.png
0cbc6ed
@OCA-git-bot @fshah-initos
pos_default_partner 12.0.1.0.1
7bdb9a4
@danimv5 @fshah-initos
Added translation using Weblate (Spanish)
9394662
@danimv5 @fshah-initos
Translated using Weblate (Spanish)
0c9fbb1 
Currently translated at 100.0% (5 of 5 strings)

Translation: pos-12.0/pos-12.0-pos_default_partner
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_default_partner/es/
@albariera @fshah-initos
[IMP] pos_default_partner: black, isort, prettier
ec3d8ce
@albariera @fshah-initos
[MIG] pos_default_partner: Migration to 13.0
26199b9
@oca-travis @fshah-initos
[UPD] Update pos_default_partner.pot
220b883
@OCA-git-bot @fshah-initos
[UPD] README.rst
68cdacb
@OCA-git-bot @fshah-initos
pos_default_partner 13.0.1.0.1
7fd224a
@fshah-initos
[IMP] pos_default_partner: isort, black, prettier
94bbeed
@fshah-initos
[MIG] Migrate module pos_default_partner to v14.
341bad5
@fshah-initos fshah-initos changed the title [14.0] [mig] posdefault partner [14.0] [mig] pos_default_partner Apr 19, 2021
@chienandalu chienandalu mentioned this pull request Apr 20, 2021
Open
16 tasks
@fshah-initos
Copy link
Contributor Author

@ValentinVinagre can you please add reviews here?

@chienandalu chienandalu added this to the 14.0 milestone Apr 26, 2021
@fshah-initos
Copy link
Contributor Author

@etobella It would be nice if you could review the PR.

@fshah-initos
Copy link
Contributor Author

It would be nice if we could get the reviews here.

etobella
etobella approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test done

dsolanki-initos
dsolanki-initos approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Functional Test and code review.

chienandalu
chienandalu approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member

@chienandalu @OCA-git-bot was not executed. Can you try again please 😉

@fshah-initos
Copy link
Contributor Author

@chienandalu Can you please try again to merge this PR?

@fshah-initos
Copy link
Contributor Author

@chienandalu It would be great if you could try to merge it again.

@chienandalu
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-627-by-chienandalu-bump-nobump, awaiting test results.

@chienandalu
Copy link
Member

Let's see now :)

@OCA-git-bot OCA-git-bot merged commit a0ac984 into OCA:14.0 Jun 7, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7bd7854. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@chienandalu chienandalu chienandalu approved these changes

@etobella etobella etobella approved these changes

@dsolanki-initos dsolanki-initos dsolanki-initos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
10 participants
@fshah-initos @OCA-git-bot @etobella @chienandalu @ivantodorovich @dsolanki-initos @bealdav @oca-travis @danimv5 @albariera