[14.0] [mig] pos_order_line_note #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Comment on lines
+4
to
+15
| By default, once ``pos_restaurant`` is installed, a warning is done, | ||
| when a pos order is created via the ``create_from_ui`` function. | ||
|
|
||
| With this module, the ``note`` field is stored in database. | ||
|
|
||
| It will avoid incorrect warning in the odoo logs: | ||
|
|
||
| .. code:: shell | ||
|
|
||
| 2020-12-22 20:33:40,567 31378 WARNING point_of_sale odoo.models: pos.order.line.create() with unknown fields: note | ||
| 2020-12-22 20:33:40,578 31378 WARNING point_of_sale odoo.models: pos.order.line.create() with unknown fields: note | ||
| 2020-12-22 20:33:40,585 31378 WARNING point_of_sale odoo.models: pos.order.line.create() with unknown fields: note |
There was a problem hiding this comment.
Suggested change
| By default, once ``pos_restaurant`` is installed, a warning is done, | |
| when a pos order is created via the ``create_from_ui`` function. | |
| With this module, the ``note`` field is stored in database. | |
| It will avoid incorrect warning in the odoo logs: | |
| .. code:: shell | |
| 2020-12-22 20:33:40,567 31378 WARNING point_of_sale odoo.models: pos.order.line.create() with unknown fields: note | |
| 2020-12-22 20:33:40,578 31378 WARNING point_of_sale odoo.models: pos.order.line.create() with unknown fields: note | |
| 2020-12-22 20:33:40,585 31378 WARNING point_of_sale odoo.models: pos.order.line.create() with unknown fields: note | |
| With this module, the ``note`` field is stored in database. |
Since 13.0 (afaik) odoo strips the unknown fields sent by the pos, so you can remove these lines
|
Yes we already have the note field in restaurant module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.