Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] pos_membership_extension #861

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[16.0][ADD] pos_membership_extension #861

merged 1 commit into from
Mar 25, 2024

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Oct 17, 2022 •
edited
Loading

Note : CI is red because of unmerged dependencies : see : OCA/vertical-association#132)

Description

This module extends the functionality of point of sale module to implement features related to membership_extension OCA module. (https://github.com/OCA/vertical-association repository) For the time being, it prevents cashier to sell product to customer that doesn't belong to some membership categories.

Configure

  • open a product form
  • Go to the sale tab
  • fill the field "Allowed Membership Categories"

product_form

  • Configure also the membership categories. For that purpose, refer to the documentation of the OCA membership_extension module.

Usage

  • open the Point of Sale product

  • You can see that some products have a new icon that mention that the product is not sallable. the icon disappear if you select a customer that belong to one of the membership categories :

point_of_sale_product_item

  • The module adds in the Product Pop Up info, the list of the membership categories allowed for the current product :

point_of_sale_popup_product_info

  • If you select the product with an incorrect customer, you'll see an error Popup :

point_of_sale_popup_error

  • If you selected allowed restricted product for a partner, and then switch for another partner, a check is realized to verify that the selected products are allowed. If not, order lines will be removed and a popup message will be displayed :

point_of_sale_switch_partner_popup

@legalsylvain legalsylvain force-pushed the 16.0-ADD-pos_membership_extension branch 4 times, most recently from 89660f3 to 9ce32d3 Compare October 17, 2022 15:24
@legalsylvain legalsylvain marked this pull request as ready for review October 17, 2022 15:36
@legalsylvain legalsylvain added this to the 16.0 milestone Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 5, 2023
@legalsylvain
Copy link
Contributor Author

CC : @PierrickBrun , could you review ?

PierrickBrun
PierrickBrun approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@PierrickBrun PierrickBrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the 2 comments everything looks perfect.

Can you rebase since the PR it depends on is merged ?

pos_membership_extension/models/product_product.py Outdated Show resolved Hide resolved
pos_membership_extension/models/product_template.py Outdated Show resolved Hide resolved
@legalsylvain legalsylvain force-pushed the 16.0-ADD-pos_membership_extension branch from 8f97bc9 to 2249de4 Compare March 6, 2023 13:17
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 12, 2023
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 16, 2023
@legalsylvain legalsylvain force-pushed the 16.0-ADD-pos_membership_extension branch from 2249de4 to 545d82d Compare July 17, 2023 09:08
@legalsylvain
Copy link
Contributor Author

thanks for your reviews.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-861-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 17, 2023
@OCA-git-bot
Merge PR #861 into 16.0
ce5506e 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-861-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 17, 2023
@OCA-git-bot
Merge PR #861 into 16.0
57ead4e 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-861-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-ADD-pos_membership_extension branch from 545d82d to d65141b Compare July 17, 2023 09:46
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 26, 2023
@github-actions github-actions bot closed this Dec 31, 2023
@legalsylvain legalsylvain reopened this Mar 8, 2024
@dreispt
Copy link
Member

dreispt commented Mar 22, 2024

/ocabot merge patch

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@legalsylvain
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-861-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d3ac870 into OCA:16.0 Mar 25, 2024
7 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8d52d10. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickBrun PierrickBrun PierrickBrun approved these changes

@PaulGoubert PaulGoubert PaulGoubert approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@legalsylvain @OCA-git-bot @dreispt @PierrickBrun @PaulGoubert