Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][16.0] pos_escpos_status #910

Merged
merged 5 commits into from
Dec 30, 2022

Conversation

nwinkelstraeter
Copy link
Member

Migration of pos_escpos_status from 14.0

Other than changing the asset definition in the manifest no changes were needed.

@nwinkelstraeter nwinkelstraeter marked this pull request as ready for review December 20, 2022 12:24
@nwinkelstraeter nwinkelstraeter mentioned this pull request Dec 20, 2022
37 tasks
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. code review / no test.
@PierrickBrun could you take a look ?
thanks !

@legalsylvain
Copy link
Contributor

/ocabot migration pos_escpos_status

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 20, 2022
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly code review, LG

@GabbasovDinar
Copy link
Member

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Dec 30, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-910-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0f3f689 into OCA:16.0 Dec 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dbf3aa3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants