[16.0][MIG] pos_access_right

[geomer198]

Migration to 16.0

[GabbasovDinar]

Code LGTM!

[hitrosol]

I activate the Multi Employees per session and add Mitchell Admin and Marc Demo as the Allowed Employees.
I set Mitchel Admin to be able to click the button discount, negative quantity, unit price change, delete Order / Many Orders. and Payment. But for Demo, i disellect all the related checkbox and the result, whenever I change the pos user in front end, I stilll can see the buttons are available.
This behavior is different with the v14.

Hope this can be fixed soon. Have a Great Job...

[jumeldi74]

I would like to add some code to enable feature whenever the cashier is changed

[hitrosol]

Let's merge this so @jumeldi74 can add feature for multi employee on top of this PR.

[ivs-cetmix]

Let's merge this so @jumeldi74 can add feature for multi employee on top of this PR.

Hi @hitrosol @jumeldi74
Thank you for your feedback!
We will take on this PR soon to get it merged.
@jumeldi74 if you have a solution for an issue described above you can suggest your code so we could merge it

[hitrosol]

Hi @isserver1, we created PR #987 and added some more features on it, such as: option to allow /disallow user to delete the order line, refund, give access for cash in/out to pos user, etc.
Maybe you are interested to review that PR so it can be merged ?

[ivs-cetmix]

Hi @isserver1, we created PR #987 and added some more features on it, such as: option to allow /disallow user to delete the order line, refund, give access for cash in/out to pos user, etc.
Maybe you are interested to review that PR so it can be merged ?

Sure. However according to the OCA rules we must do migration first. And later add new features in new PRs

[hitrosol]

if so, can you make the codecov green so it can be approved and merged? @jumeldi74 will make new PR to add features on top of it.

[ivs-cetmix]

if so, can you make the codecov green so it can be approved and merged? @jumeldi74 will make new PR to add features on top of it.

AFAIK codecove is not a mandatory check. Especially when it comes to the migration PR

[legalsylvain]

/ocabot migration pos_access_right

[legalsylvain]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-957-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

@legalsylvain The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-957-by-legalsylvain-bump-nobump:16.0 failed with output:

To https://github.com/OCA/pos
 ! [rejected]          16.0-ocabot-merge-pr-957-by-legalsylvain-bump-nobump -> 16.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/pos'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

[ivs-cetmix]

hi @legalsylvain I have updated the branch, please try again

[legalsylvain]

the last commit looks useless. could you run git pull 16.0 --rebase to remove it ?

[ivs-cetmix]

the last commit looks useless. could you run git pull 16.0 --rebase to remove it ?

done

[legalsylvain]

Thanks !

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-957-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 9a1ae3a. Thanks a lot for contributing to OCA. ❤️