Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] pos_order_mgmt: Migration to 14.0 #994

Merged
merged 74 commits into from
May 4, 2023

Conversation

zamberjo
Copy link
Member

@zamberjo zamberjo commented May 3, 2023

Note: PR is required to avoid error when testing the return with the "In real time" configuration parameter.

@zamberjo zamberjo mentioned this pull request May 3, 2023
16 tasks
@legalsylvain
Copy link
Contributor

/ocabot migration pos_ordre_mgmt

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone May 3, 2023
@pedrobaeza
Copy link
Member

/ocabot migration pos_order_mgmt

@pedrobaeza
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The rebase process failed, because command git push --force aurestic tmp-pr-994:14.0-mig-pos_order_mgmt failed with output:

remote: Permission to aurestic/pos.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/aurestic/pos/': The requested URL returned error: 403

@pedrobaeza
Copy link
Member

pedrobaeza commented May 3, 2023

@zamberjo please rebase now that the other PR is merged.

chienandalu and others added 22 commits May 4, 2023 07:22
When the PoS is using fiscal positions it can lead to errors when
computing the reprinted ticket value because the tax mapping function
computes them from the current order instead of from the one belonging
to the line. So we set our loaded order temporarily as the selected one
just to bring it back to the current one after it's printed.
Currently translated at 100.0% (20 of 20 strings)

Translation: pos-11.0/pos-11.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_order_mgmt/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-11.0/pos-11.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_order_mgmt/
- Fix search clear button

- Refactor load_order and actions

This refactors load_data into two functions: load_order_data and load_order_from_data.
Also, when executing actions, instead of sending the order as an argument, only the order_data will be sent.
The action method is responsible for generating the order data (if that's what it needs)

All the refund logic has been extracted from the various methods, and it's now in action_return.

Now, returns have a specific 'Refund XXXX' name.

- IMP Allow to duplicate done orders from the POS

- IMP filter by customer name, too, when searching
[FIX] compatibility with pos_restaurant OCA#339 cortesy @carlosDomatix
[FIX] add _compute_refund_order_qty
[ADD] pos order view form. Add links to original returned order and refund orders.
[IMP] when refunding an order via the 'Refund' button in back office, set the correct returned_order_id.
[IMP] Add helper on each button
[ADD] python test
[REF] JS remove useless code
[REF] Python remove useless code
[FIX] remove bad oldname
[FIX] remove gap in bill display, when it is a refund
[FIX] when reprinting a bill, the returned order name is displayed, if any
[FIX] JS lint, with OCA eslint file
[ADD] french translation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
…n order, if the user refreshes the browser the order will load again. And this will happen for every previously printed order in the session.
brendapaniagua and others added 14 commits May 4, 2023 07:22
Currently translated at 97.1% (34 of 35 strings)

Translation: pos-12.0/pos-12.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/
Currently translated at 100.0% (35 of 35 strings)

Translation: pos-12.0/pos-12.0-pos_order_mgmt
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_mgmt/ca/
@zamberjo
Copy link
Member Author

zamberjo commented May 4, 2023

@zamberjo please rebase now that the other PR is merged.

Done. I had to set "development_status": "Alpha", so that it would run the tests.

@pedrobaeza
Copy link
Member

OK. I think pos_order_return deserves to be promoted to at least beta (but better to stable), but for now it's enough.

Copy link

@belenaures belenaures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @zamberjo 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-994-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c5129ed into OCA:14.0 May 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 08d8892. Thanks a lot for contributing to OCA. ❤️

@zamberjo zamberjo deleted the 14.0-mig-pos_order_mgmt branch May 4, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.