[MIG][16.0] product_packaging_type + renaming to product_packaging_level

[rousseldenis]

Following this discussion:

#1213

Depends on:

• [IMP] rename_models: Avoid mogrify 'IndexError: tuple index out of range' for % LIKE parameter openupgradelib#312

[rousseldenis]

/ocabot migration product_packaging_type

[rousseldenis]

@ChrisOForgeFlow @LoisRForgeFlow You should be interested by this.

I've put changes in separate commits, so you maybe want to port this to 15

[lmignon]

@rousseldenis The UI isn't working at all.... It's not possible to add new packaging on the product forms.. the packaging type remains always the same etc...

[rousseldenis]

@rousseldenis The UI isn't working at all.... It's not possible to add new packaging on the product forms.. the packaging type remains always the same etc...

Ok, I check

[rousseldenis]

@lmignon Seems better now

[lmignon]

This code LGTM (also functional tests) but I've some difficulties to understand the difference between packaging type and packaging level. Can you elaborate and add some informations into the readme plz.

[rousseldenis]

@jbaudoux Maybe an advice here on how to describe functionally this module and how this is different from packaging type?

[jbaudoux]

It is missing a small feature to ease the configuration. On the package type, we should be able to configure a package level and when we select a package type on the product packaging, it should set the right package level on the product packaging.

[remytms]

@rousseldenis I have a question. Why putting this update of the table in a pre-init-hook instead of putting it in a pre-migration.py script in the migration directory of this module ?

Is the pre-init-hook launched when performing an update of the module ? I thought that it only runs when installing the module, but I may be wrong.

[bealdav]

Not sure on my side but I suppose there is no update here.
You install a new module (new name).
Installing it, you move data with this hook.
It seems logic to me but @rousseldenis will give the good response

[rousseldenis]

@remytms @bealdav Because as the module is renamed, it is not yet installed. So, pre-init is the good entry point.

[bealdav]

Thanks for this renaming, make it more explicit.
I would like to test with runboat before make final review.
Could you try to regenerate it ?
Thanks

[rousseldenis]

Thanks for this renaming, make it more explicit. I would like to test with runboat before make final review. Could you try to regenerate it ? Thanks

@bealdav Done

[jbaudoux]

@rousseldenis Can you update the readme and add the missing link between package type & level. Cf #1215 (review)

[bealdav]

LGTM, really thanks.

Thanks to update doc.

[rousseldenis]

@jbaudoux Done

[jbaudoux]

Let's merge this. The small missing feature can be done in a later PR

[jbaudoux]

/ocabot merge nobump

[OCA-git-bot]

Sorry @jbaudoux you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[rousseldenis]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1215-by-rousseldenis-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 33af21a. Thanks a lot for contributing to OCA. ❤️