[14.0] [purchase_advance_payment] wrong residual amount when reconciling credit note with invoice

[ygol]

Module

purchase_advance_payment

Describe the bug

When reconciling an bill with a vendor credit note, the residual amount is false. As the vendor credit note amount is subtracted twice.

To Reproduce

tested 14.0

Steps to reproduce the behavior:

1. create a PO, confirm + create an invoice
2. edit the above PO and add a new line with negative amount, confirm + create bill
3. reconcile the available vendor credit note amount on the vendor bill
4. Get wrong residual amount = 360000
   

Expected behavior
Residual amount to be 480000

Additional context
Add any other context about the problem here. (e.g. OS, Python version, ...)

[ygol]

the problem is that the PO total amount has already discounted the value of the credit note and when we reconcile the credit note with the invoice it is thus deducted a 2nd time when

purchase-workflow/purchase_advance_payment/models/purchase_order.py

Line 87 in c186f08

invoice_paid_amount += inv.amount_total - inv.amount_residual

[HviorForgeFlow]

ping @MateuGForgeFlow

[HviorForgeFlow]

@ygol We will be more than excited to review your fix proposal

[djtao1]

I am also very troubled by this issue. Is there a plan or possibility to fix this issue? thanks for support!

[rvalyi]

cc @clementmbr @PierrickBrun @NathanQj

[djtao1]

I have tested the latest version and it appears to be functioning correctly. but how to correct the erroneous entry caused by this issue earlier. They don't seem to have been automatically corrected.

[ygol]

I have tested the latest version and it appears to be functioning correctly. but how to correct the erroneous entry caused by this issue earlier. They don't seem to have been automatically corrected.

hi @djtao1 working on a solution in #1862