Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] use commercial_partner_id on prepare_payment_vals method #2420

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from

Conversation

njeudy
Copy link

@njeudy njeudy commented Oct 1, 2024

  • If partner_id is used when creating payment, invoice will not detect advance payment to reconcile. so replace by commercial_partner_id.
  • code for invoice_paid_amount is not correct, just use amount_total and amount_residual to keep it simple !

@njeudy njeudy force-pushed the 14.0-FIX-purchase_advance_payment branch from 6437c6b to e64066b Compare October 1, 2024 09:03
@njeudy
Copy link
Author

njeudy commented Oct 1, 2024

@MateuGForgeFlow @HviorForgeFlow can you review it and merge ?

@njeudy njeudy force-pushed the 14.0-FIX-purchase_advance_payment branch from e64066b to da77183 Compare October 1, 2024 10:06
@njeudy
Copy link
Author

njeudy commented Oct 1, 2024

I teste it with invocie, advance and credit note and with partial payment, and now it works .. think we should update V15, V16 and V17 as well ?

@HviorForgeFlow
Copy link
Member

@njeudy I'm not sure about this change because in the past as you can see here there was an issue regarding the change that you revert on da77183

@ygol @djtao1 can you give some feedback and review please, thanks :)

I personally never had the chance to use this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants