[ADD] attribute-string-redundant: Check if the string parameter is eq…

[JesusZapata]

Check if the name of the variable is equal to string parameter

Tested cases

name_equal_to_string = fields.Float("Name equal to string") # Show warning
many_2_one = fields.Many2one('res.users', "Many 2 one") # Show warning
many_2_many = fields.Many2many('res.users', 'relation', 'fk_column_from', 'fk_column_to', "Many 2 many") # Show warning

This change is supported by CONTRIBUTING guide of oca

If the technical name of the field (the variable name) is the same as the string of the label, do not put string parameter for new API fields, because it's automatically taken. If your variable name contains "_" in the name, they are converted to spaces when creating the automatic string and each word is capitalized. (Example: old api 'name': fields.char ('Name', ...) new api 'name': fields.Char (...))

https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#fields

[oca-clabot]

Hey @JesusZapata, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

• @JesusZapata (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

[moylop260]

Please update this pr with last changes and fixes
And fix conflicts

[JesusZapata]

@moylop260
Done!
I applied this solution Vauxoo#108 in this PR

[moylop260]

Sorry new conflicts

[JesusZapata]

@moylop260
Done! I fixed this conflict!

[moylop260]

@lasley @pedrobaeza @dreispt @lmignon
your feedback is welcome

[lasley]

I ❤️ it!

It will be nice to be able to remove this from the mental checklist of things to look for during PR reviews - it's a common mistake too, particularly from older code.

[oca-clabot]

Hey @JesusZapata,
We acknowledge that the following users have signed our Contributor License Agreement:

• @JesusZapata

Appreciation of efforts,
OCA CLAbot