[FIX] pylint-odoo: modify dangerous-view-replace-wo-priority to check all child tags with replace #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandahf
force-pushed
the
master-review-dangerous-view-wo-fer
branch
from
d3983d6
to
0112714
Compare
|
Could you review this, please? Regards. |
luisg123v
suggested changes
Dec 23, 2020
fernandahf
force-pushed
the
master-review-dangerous-view-wo-fer
branch
2 times, most recently
from
f8dd84b
to
e13b9f2
Compare
Done |
|
I think that its ready. |
luisg123v
suggested changes
Dec 23, 2020
There was a problem hiding this comment.
Hi @fernandahf,
Remember commit description is as (and sometimes more) as important than the PR description.
Could you copy PR description in the commit description, please?
| @@ -88,7 +88,7 @@ | |||
| </form> | |||
| </field> | |||
| </record> | |||
| <!-- Replace with low priority eval--> | |||
| <!-- --> | |||
There was a problem hiding this comment.
No, sorry, was an error.
… all child tags with replace
Consider next case:
<record id=crm_case_form_view_leads_form_inherit model=ir.ui.view>
<field name=name>crm.lead.form.lead</field>
<field name=model>crm.lead</field>
<field name=inherit_id ref=crm.crm_case_form_view_leads/>
<field name=arch type=xml>
<label for=contact_name position=replace/>
...
</field>
</record>
Part of code where replace is use is a label tag and pylint-odoo does not recognize it, however, Odoo convert this part of code in a xpath tag with replace attribute but in that point already passed lint.
fernandahf
force-pushed
the
master-review-dangerous-view-wo-fer
branch
from
e13b9f2
to
1fc84f5
Compare
|
Could you review this again, please? Regards. |
luisg123v
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Consider next case:
Part of code where replace is use is a label tag and pylint-odoo does not recognize it, however, Odoo convert this part of code in a xpath tag with replace attribute but in that point already passed lint.
Current behavior before PR: warnings of code like above not found.
Desired behavior after PR is merged: warnings of code like above found.
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr