-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] queue_job: Add split method #658
Conversation
Hi @guewen, |
f1e4b8b
to
6131cf1
Compare
6131cf1
to
feab369
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The coverage does not seem to include the unittest :/ |
Import the new test in |
facdc08
to
46f344e
Compare
They weren't run as they were |
46f344e
to
3865f14
Compare
I added a chain parameter to split into a chain instead of a group. Is there anything lacking for this to be merged? |
Just the attention of @OCA/connector-maintainers |
This PR has the |
1 similar comment
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Just some minor remarks :)
@guewen ping :)
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
3865f14
to
53558ed
Compare
As this is not touching any existing feature and is not adding a lot of code IMO we can move on w/ the merge. |
53558ed
to
f929b64
Compare
Done |
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at cf2ff24. Thanks a lot for contributing to OCA. ❤️ |
This is a draft PR trying an alternative approach for #566
The
split
function onDelayable
returns aDelayableGroup
.This is an attempt and I am open to suggestions