Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] printer_zpl2: Do use colspan=2 for the ace widget fields so you can use it #343

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[16.0][FIX] printer_zpl2: Do use colspan=2 for the ace widget fields so you can use it #343

merged 1 commit into from
Oct 7, 2024

Conversation

wpichler
Copy link

@wpichler wpichler commented Dec 6, 2023

Some minor form view fixes - without colspan="2" the ace widget is not useable

@micheledic
Copy link

any news about merge?

@pedrobaeza
Copy link
Member

@wpichler pre-commit is not correct.

@micheledic Do reviews for favoring their merges: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#L1345

@pedrobaeza pedrobaeza added this to the 16.0 milestone Mar 20, 2024
@pedrobaeza
Copy link
Member

@wpichler please check pre-commit issue.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@github-actions github-actions bot closed this Oct 6, 2024
@micheledic
Copy link

@pedrobaeza @wpichler the Issue Is still there

@pedrobaeza pedrobaeza reopened this Oct 7, 2024
@pedrobaeza pedrobaeza changed the title [FIX] Do use colspan=2 for the ace widget fields so you can use it [16.0][FIX] Do use colspan=2 for the ace widget fields so you can use it Oct 7, 2024
@pedrobaeza pedrobaeza changed the title [16.0][FIX] Do use colspan=2 for the ace widget fields so you can use it [16.0][FIX] printer_zpl2: Do use colspan=2 for the ace widget fields so you can use it Oct 7, 2024
@pedrobaeza pedrobaeza force-pushed the 16.0-printer_zpl2_fix_views-wpichler branch from 0452bba to 04551cb Compare October 7, 2024 05:59
@pedrobaeza
Copy link
Member

I have pushed a version with no pre-commit problem for merging this:

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-343-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 5a520df into OCA:16.0 Oct 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c199434. Thanks a lot for contributing to OCA. ❤️

@micheledic micheledic mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@micheledic micheledic micheledic approved these changes

Assignees
No one assigned
Labels
approved help wanted merged 🎉 needs fixing ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wpichler @micheledic @pedrobaeza @OCA-git-bot @dreispt