Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FW] oca-port: forward missing commits from 14.0 #370

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][FW] oca-port: forward missing commits from 14.0 #370

wants to merge 3 commits into from

Conversation

trisdoan
Copy link

This change

  • Took this occasion to
    • fix access right:
      • Access rights were added in c7fac1b
      • But the author missed to add create access for the wizard, which results in Access Error when clicking 'Update Printers from CUPS'
    • fix wrong translated term

@trisdoan trisdoan mentioned this pull request Oct 14, 2024
Open
sebalix
sebalix requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 04695e7 should not be ported, it is adding a whole module so it's not a changeset to port but to will have to be migrated in its own PR later.

@trisdoan trisdoan force-pushed the oca-port-base_report_to_printer-14.0-to-17.0-17b2c3 branch from 744ff55 to 64320ca Compare October 24, 2024 10:36
@trisdoan trisdoan requested a review from sebalix October 24, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix Awaiting requested review from sebalix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trisdoan @sebalix @rousseldenis