[FIX] Fixed the res.users view #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoelAdriaans
approved these changes
Jan 17, 2017
pedrobaeza
reviewed
Jan 17, 2017
| @@ -6,12 +6,12 @@ | |||
| <field name="model">res.users</field> | |||
| <field name="inherit_id" ref="base.view_users_form" /> | |||
| <field name="arch" type="xml"> | |||
| <page string="Preferences"> | |||
| <group name="printing"> | |||
| <xpath expr="//page[group/group[@name='preferences']]" position="inside"> | |||
There was a problem hiding this comment.
You can put it even more generic:
<xpath expr="//group[@name='preferences']/ancestor::page" position="inside">
There was a problem hiding this comment.
Thanks, I didn't know this syntax, I update with your version.
If there are several page ancestors, would it take the first or the last ?
There was a problem hiding this comment.
It would take the first, although you can put also indexes if needed, but it's not the usual case.
The string attribute should not be used as a selector, because it is translatable.
Garamotte
force-pushed
the
9.0-fix-res_users-view
branch
from
1c558d0
to
b9e9f62
Compare
pedrobaeza
approved these changes
Jan 18, 2017
lasley
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string attribute should not be used as a selector, because it is translatable.
cc @RoelAdriaans-B-informed