report_xlsx: fix report context propagation on records

[simahawk]

Without this change If you return a custom action that sets a custom context -> you lose it -> if your report depends on it... it's broken 😭

@adrienpeiffer @sbidoul this fixes XLS export on mis.report.instance 😉

Fixes #326

[simahawk]

digging into this issue turns out that if you don't pass data in the action you return, you won't get anything into data in the controller 🤔

[sbidoul]

@simahawk in mis builder 10, we have this https://github.com/OCA/mis-builder/blob/be28ba9de4c67bbc4339522bdb1686b4e942ada3/mis_builder/models/mis_report_instance.py#L618-L627 and it works fine.

[simahawk]

@sbidoul but that code has been migrated already to v11 since there's not get_action.
Anyway, the issue is not there. What you have in mis_builder now is:

return {
            'name': 'MIS report instance XLSX report',
            'model': 'mis.report.instance',
            'type': 'ir.actions.report',
            'report_name': 'mis_builder.mis_report_instance_xlsx',
            'report_type': 'xlsx',
            'report_file': 'mis_report_instance',
            'context': context,
        }

and this does not work.
If I apply this patch, it does not work neither, unless I change the dict above like:

[...]
            'context': context,
            'data': {'__make_report_controller_work__': 1},

by adding data key. However, its content doesn't matter...

[sbidoul]

@simahawk is this still WIP?

[simahawk]

@sbidoul I'm not working on this since ages 😅
Actually I was waiting for feedback, especially on the fact that we have to add a fake data dict anyhow to make it work 🤷‍♂️

[sbidoul]

All I can say is the fake data dict is needed to propagate the context for pdf reports too. So at least the hack is consistent ;) Why it is so is beyond me...

[simahawk]

Why it is so is beyond me...

It's because the controller relies on the automatic conversion of the params in the request and if the param is not in the request they ignore it completely 🤦‍♂️

[simahawk]

ok then I'll update this PR w/ a mention in the docs

[sbidoul]

@simahawk I just debugged a bit, and I think the context is actually lost here:

reporting-engine/report_xlsx/models/ir_report.py

Lines 19 to 21 in 9eb9a42

	return report_model.with_context({
	'active_model': self.model
	}).create_xlsx_report(docids, data)

So replacing that with with_context(active_model=self.model) (plus the data hack in the report action), it seems to work.

[simahawk]

I removed context manipulation and fixed up the places where the context was replaced instead of updated. I cannot test it now, I'll see if someone else can.

[jffernandez]

I think that to fix the context propagation only is needed one change, with that it works.
See inline comments.
Thank you for your PR!

[sbidoul]

@simahawk if you'd have 2 minutes to revert the **context changes which are not really necessary?

For the rest I tested and the fix works fine. Thanks!

[simahawk]

I changed "blindly" what have you asked for, no time to test, sorry guys :/

[sbidoul]

Thanks!

/ocabot merge patch

fixes #326

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-259-by-sbidoul-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 532e84e. Thanks a lot for contributing to OCA. ❤️