[16.0 ][OU-FIX] loyalty_criteria_multi_product: column type + condition + criteria + repeat_product #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chienandalu, |
pedrobaeza
force-pushed
the
16.0-ou_fix-loyalty_criteria_multi_product
branch
from
5c36ffa
to
aa56917
Compare
…iteria + repeat_product - It should be VARCHAR, not CHAR. - Remove the condition for assigning the rule (as there can be m2m linked products although there criteria selection is another). - Do the product m2m handle. - Do the repeat_product handlement by SQL + fix it.
pedrobaeza
force-pushed
the
16.0-ou_fix-loyalty_criteria_multi_product
branch
from
aa56917
to
dde5254
Compare
|
Tested in real migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa