Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 9.0 #223

Closed
8 of 50 tasks
pedrobaeza opened this issue Oct 14, 2015 · 19 comments
Closed
8 of 50 tasks

Migration to version 9.0 #223

pedrobaeza opened this issue Oct 14, 2015 · 19 comments
Labels
help wanted stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress
Milestone

Comments

@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 14, 2015

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

Modules to migrate

@jaredkipe
Copy link
Contributor

Records for 'workflow.transition' require fields 'act_from' and 'act_to' like the following.
<field name="act_from" ref="act_draft"/> <field name="act_to" ref="act_sent"/>

@SodexisTeam
Copy link
Member

@pedrobaeza
These 2 modules are not available in the Modules to migrate list. Why?

  • sale_payment_method_automatic_workflow
  • sale_exceptions

I need these 2 modules to be ported for OCA/connector-ecommerce.

@pedrobaeza
Copy link
Member Author

That's because they were added after this issue was created. I have added them and assigned to you.

@stephankeller
Copy link

@pedrobaeza Thanks.

@yajo
Copy link
Member

yajo commented May 26, 2016

I'm starting with sale_packaging_price

@guewen
Copy link
Member

guewen commented May 27, 2016

@SodexisTeam sale_payment_method_automatic_workflow is replaced by sale_automatic_workflow_payment_mode in #297

@nicomacr
Copy link
Contributor

I've propose migration of sale_order_type in this pr #340

@LoisRForgeFlow
Copy link
Contributor

Migration of partner_prepayment might be not needed as the feature provided is covered in #434. What do you think?

@LoisRForgeFlow
Copy link
Contributor

sale_validity is in #447

@AMhadhbi
Copy link
Member

@pedrobaeza what about module sale_quick_payment. it should be migrate or it is already merged with other module? thanks

@pedrobaeza
Copy link
Member Author

@AMhadhbi modules that weren't present in the repository when the 9.0 branch was created are not populated automatically in this list, but if it deserves to be migrated, we can add it.

@florian-dacosta
Copy link
Contributor

@AMhadhbi you can check this : #403

@AMhadhbi
Copy link
Member

@florian-dacosta Thank you. I check it, you are right sale_quick_payment depend on sale_payment_method. also sale_payment_method not already migrated.
@pedrobaeza should migrate sale_payment_method? then migrate sale_quick_payment. and we will migrate to version 10 and v11. or we will work on this pull request #403 and merge them with sale_payment. what do you suggest?

@pedrobaeza
Copy link
Member Author

Well, I don't know both, but it seems that #403 is in good shape, and accounting has changed a lot in v9, so probably go for this PR is a better option.

@florian-dacosta
Copy link
Contributor

sale_payment was meant to replace sale_quick_payment + sale_payment_method.
I should have notified that here actually, my mistake.

@AMhadhbi sale_payment_method should not be migrated, because the sale.payment model has been replaced by account.payment.mode, which is implemented here : https://github.com/OCA/bank-payment/tree/9.0/account_payment_mode

@AMhadhbi
Copy link
Member

@florian-dacosta very good. you already answer my question how to replace object payment.method thank you very much.
sure your PR is a good way. sale_quick_payment will be replaced with sale_payment and sale_payment_method already migrated with account_payment_mode. Perfect !

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Oct 3, 2020

Can I just ask how you all like the convergence between the old payment.method from sale_payment method and account.payment.mode as per this edition's migration? We are running a multi-company Magento site migrating away from version 8.0. For us, the payment.method is just a label determined in Magento by the payment provider that we can use in Odoo to apply the ecommerce import_rule, workflow_process_id and days_before_cancel settings. These settings are the same across our entities so these payment.method's don't have a company set. For us, this payment.method model does not have anything to do with the actual payment.

In our migration, because of the convergence with account.payment.method, I'm having trouble assigning all kinds of required fields that are company dependent (not in the first place the required company_id itself). Expanding this table with separate entries for each individual company would ruin the usability (we have a lot of entries already).

Do you agree that this old payment.method could maybe return as a new ecommerce.payment.method with just these import related settings? We could add a payment_mode_id on this model to optionally set the sale order's payment_mode_id. I would be proposing a proof-of-concept for version 12 that could be included in the code for version 14.

@OCA OCA deleted a comment from SodexisTeam Oct 5, 2020
@OCA OCA deleted a comment from SodexisTeam Oct 5, 2020
@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021
@daramousk
Copy link
Member

Is the sale_order_merge module not used anymore? I do not see any references to its migration or any other reference to it.

norlinhenrik pushed a commit to loymcom/sale-workflow that referenced this issue Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress
Projects
None yet
Development

No branches or pull requests