Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] impersonate_login: fix user_id comodel_name #686

Merged
merged 1 commit into from
Oct 19, 2024
Merged

[17.0][FIX] impersonate_login: fix user_id comodel_name #686

merged 1 commit into from
Oct 19, 2024

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Sep 1, 2024

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @Kev-Roche,
some modules you are maintaining are being modified, check this out!

@astirpe astirpe changed the title [FIX] impersonate_login: fix user_id comodel_name [17.0][FIX] impersonate_login: fix user_id comodel_name Sep 1, 2024
@astirpe astirpe marked this pull request as ready for review September 1, 2024 07:52
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@astirpe astirpe mentioned this pull request Oct 17, 2024
Open
@rvalyi
Copy link
Member

rvalyi commented Oct 17, 2024

/ocabot merge minor

simahawk
simahawk reviewed Oct 18, 2024
View reviewed changes
impersonate_login/models/impersonate_log.py
@@ -11,7 +11,7 @@ class ImpersonateLog(models.Model):
_description = "Impersonate Logs"

user_id = fields.Many2one(
comodel_name="res.partner",
comodel_name="res.users",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it require any migration for existing records?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk this is the fix already merged in V16 51eccf8

The integer written in user_id is a res.users anyway, so no need of migration

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-686-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4aef25f into OCA:17.0 Oct 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba7dc4a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@rvalyi rvalyi rvalyi approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@Kev-Roche Kev-Roche Kev-Roche approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@astirpe @OCA-git-bot @rvalyi @simahawk @CasVissers-360ERP @Kev-Roche