Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] impersonate_login #722

Open
wants to merge 3 commits into
base: 14.0
Choose a base branch
from

Conversation

toita86
Copy link

@toita86 toita86 commented Oct 31, 2024

MIG/ADD of #637

I have decided to adopt the approach from the original PR and adjust the tests, rather than
backporting from v16 which would have required too many rollbacks to make it compatible with v14.

Kev-Roche and others added 3 commits October 30, 2024 15:47
…eation

- Ensure impersonation is properly reflected in record creation
- Update related tests to verify correct impersonation behavior
@toita86 toita86 marked this pull request as ready for review October 31, 2024 11:12
@toita86
Copy link
Author

toita86 commented Oct 31, 2024

@Kev-Roche @astirpe, can you please checkout my implementation for the _create() method?
It is the only way i found to guarantee the correct assignment for create_uid and to get the tests passing.
If you have any concerns or suggestions for improvement, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants