Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] auditlog: Migration to 18.0 #3054

Open
wants to merge 176 commits into
base: 18.0
Choose a base branch
from

Conversation

lembregtse
Copy link
Contributor

No description provided.

@lembregtse lembregtse mentioned this pull request Oct 8, 2024
24 tasks
@gurneyalex
Copy link
Member

Warning, there is an issue on 17.0 resulting in some workers not implementing the correct logging.

#3088 is supposed to fix it.

@etobella
Copy link
Member

/ocabot migration auditlog

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 26, 2024
@StefanRijnhart
Copy link
Member

@lembregtse Can you update your branch to include #3088 which is now merged?

@mylbco
Copy link

mylbco commented Dec 2, 2024

@lembregtse any update on this ;-)

sebalix and others added 24 commits December 5, 2024 08:32
…itlog.log' model (standard 'create_date' field is used instead)
BT-anieto and others added 11 commits December 5, 2024 08:33
When adding/removing a group in a user (and tracking a user or a partner), odoo sends a 'reified' val 'in_group_{group_id}'. We must convert this value into the real groups_id one.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-auditlog
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/
Currently translated at 100.0% (87 of 87 strings)

Translation: server-tools-17.0/server-tools-17.0-auditlog
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/it/
Currently translated at 100.0% (87 of 87 strings)

Translation: server-tools-17.0/server-tools-17.0-auditlog
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/es/
Currently translated at 100.0% (87 of 87 strings)

Translation: server-tools-17.0/server-tools-17.0-auditlog
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/sv/
Currently translated at 100.0% (87 of 87 strings)

Translation: server-tools-17.0/server-tools-17.0-auditlog
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/zh_CN/
Currently translated at 100.0% (87 of 87 strings)

Translation: server-tools-17.0/server-tools-17.0-auditlog
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/es_AR/
@lembregtse lembregtse force-pushed the 18.0-mig-auditlog branch 2 times, most recently from 79799f9 to e31bf35 Compare December 5, 2024 07:46
@lembregtse
Copy link
Contributor Author

@StefanRijnhart @mylbco FYI, I've redone the PR. I somehow missed your messages!

@StefanRijnhart
Copy link
Member

@lembregtse thanks! There is a fixup commit involved in that last merge. This would be the right moment to squash it if you would be so kind.

gurneyalex and others added 2 commits December 5, 2024 09:28
When a new auditlog rule is added / modified / deleted, all workers
need to be notified of the change. This is done through registry
signaling. The previous code was not using the proper level of signaling
resulting in workers not being aware of the changes and not implementing
the correct auditlog rules, because they had only invalidated their
cache and not reloaded the registry.

We fix this by using the same signaling as implemented in
`base_automation` which sets the the registry_invalidated field of
env.registry to True to cause a full registry reload.
@lembregtse
Copy link
Contributor Author

@StefanRijnhart misunderstood, but squashed now!

@StefanRijnhart
Copy link
Member

@lembregtse Thanks, but now I'm confused about the message in the migration commit.
image
Was something squashed here? What change in the commit prevents empty logs? Is it related to #3137?

@lembregtse
Copy link
Contributor Author

@StefanRijnhart my bad, I seem to have "Ctrl+R'ed" into a commit message I used back then to try (as you mentioned) something locally for Raf's fix in the other PR.

I've removed the message from the commit, it was not relevant here, it was for a squash I did to fix the cron data file (removing doall and numbercall).

I've changed the version number as well!

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looking even better than before!

@ristecona
Copy link

if possible please merge, thanks a lot

@StefanRijnhart
Copy link
Member

@ristecona A technical of functional review would be appreciated!

@MiquelRForgeFlow
Copy link
Contributor

@lembregtse please cherry-pick #3147

@StefanRijnhart
Copy link
Member

And #3137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.