Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] base_import_odoo #3136

Merged
merged 46 commits into from
Dec 12, 2024
Merged

Conversation

thomaspaulb
Copy link
Contributor

@thomaspaulb thomaspaulb commented Dec 4, 2024

Continuation of #3004

hbrunn and others added 30 commits December 4, 2024 11:11
[ADD] debug logging
* [ADD] create an xmlid for mapped records too
* [IMP] filter out unknown fields
* [FIX] warning about exception handling
@thomaspaulb thomaspaulb marked this pull request as ready for review December 4, 2024 11:35
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to have maintainers recorded on modules, would you mind adding yourself and me?

@thomaspaulb thomaspaulb force-pushed the 16.0-mig-base_import_odoo branch from f962f21 to 95727ee Compare December 5, 2024 10:13
@thomaspaulb
Copy link
Contributor Author

@hbrunn Added

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Dec 12, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3136-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 12, 2024
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3136-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@thomaspaulb
Copy link
Contributor Author

2024-12-12 12:32:49,277 415 INFO odoo odoo.addons.auditlog.tests.test_multi_company: ====================================================================== 
2024-12-12 12:32:49,277 415 ERROR odoo odoo.addons.auditlog.tests.test_multi_company: FAIL: TestMultiCompany.test_group_set_users_with_auditlog
Traceback (most recent call last):
  File "/__w/server-tools/server-tools/auditlog/tests/test_multi_company.py", line 113, in test_group_set_users_with_auditlog
    self.test_group_set_users()
  File "/__w/server-tools/server-tools/auditlog/tests/test_multi_company.py", line 86, in test_group_set_users
    self.assertEqual(group_with_user.users, self.user2)
AssertionError: res.users(11, 12) != res.users(12,)

:-/

@hbrunn
Copy link
Member

hbrunn commented Dec 12, 2024

fixed in #3146

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3136-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b95dd4a into OCA:16.0 Dec 12, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3201ef5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants