Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] base_revision: UX, open Form if only one revision record #937

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] base_revision: UX, open Form if only one revision record #937

wants to merge 1 commit into from

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Aug 20, 2024

Forward port of #936

@dreispt dreispt force-pushed the 16-dr-base_revision branch from 5b868cf to 87aa303 Compare August 20, 2024 14:24
SirAionTech
SirAionTech approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Only code review, looks good to me.

A test would be nice, but not blocking in my opinion because it's a very little change.

@dreispt
Copy link
Member Author

dreispt commented Aug 23, 2024

This is a client UI action. I'm sot sure how I could test it. Any example you could share?

@SirAionTech
Copy link
Contributor

This is a client UI action. I'm sot sure how I could test it. Any example you could share?

I was thinking to simply check in Python what create_revision returns when it creates only one revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreispt @SirAionTech