[13.0] [MIG+REF] mass_editing #94

legalsylvain · 2019-09-30T09:08:26Z

mass_editing improvment :

renaming mass.object to mass.editing for consistency
make options (set / add / remove) translatable
simplify mass.editing.wizard (V12: 300 lines ; V13: 160 lines)
make easier and add modularity in the mass.editing.wizard python code.
replace field_ids M2M fields by a new modelmass.editing.line to have the possibility to order fields in the wizard, by a sequence and to select the widget for each field.

migration Script.

Add abstraction (mass.operation.abstract)

Introducing a new abstract module mass_operation_abstract to provide mixin objects that allow to make mass operation on many items of any models
make mass_editing depending on mass_operation_abstract

oca-clabot · 2019-09-30T09:08:29Z

Hey @legalsylvain, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@AnuKPatel (login unknown in OCA database)
@dsabrinarg (login unknown in OCA database)
Unknown (no github login found)

Appreciation of efforts,
OCA CLAbot

legalsylvain · 2019-10-03T16:09:09Z

ready for review. cc : @SerpentCS

legalsylvain · 2019-10-03T16:15:23Z

For your information others module will come depending on the module mass_operation_abstract. like this one : mass_action to execute python code for many items.

ref : https://github.com/grap/grap-odoo-incubator/tree/8.0/mass_action

mass_operation_abstract/wizard/mass_operation_wizard_mixin.py

SerpentCS · 2019-10-26T14:53:06Z

Looks good (y). should not you make another PR for second module mass_operation_abstract?

legalsylvain · 2019-10-26T17:28:26Z

Looks good (y).

Thanks ! Is it an approval ? ;-)

should not you make another PR for second module mass_operation_abstract?

Well, I split the module mass_editing in two modules, with a dependency. So it makes no sense to make two separate PR as one can not be merged without the other. And if spitted, it will be more complicated for reviewer to see what code moved in the abstract module.

SerpentCS · 2019-10-27T04:37:08Z

Its an approval yes!

tarteo

Is this module still relevant in 13.0 since there is multi_edit="1"?

legalsylvain · 2019-12-20T15:03:05Z

Hi @tarteo : Thanks for your review. Regarding your question, did you read the description of the new module ? I think it answers to your question in the section "Difference between the Odoo 13.0 CE Feature"

https://github.com/legalsylvain/server-ux/blob/13.0-MIG-mass_editing/mass_editing/readme/DESCRIPTION.rst

Let me know if you still have questions.

legalsylvain · 2019-12-20T15:03:57Z

hi @bealdav I took into account your remarks. Could you update your review ?

Thanks !

bealdav

Thanks. Please merge all fixup commits

OCA-git-bot · 2019-12-20T18:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain · 2019-12-21T08:20:40Z

Oca bot merge fixup commit. Doesnt he?

bealdav · 2019-12-21T16:54:45Z

No sorry

MiquelRForgeFlow · 2020-01-30T16:07:45Z

@legalsylvain please squash fixup commits

ivantodorovich

code & functional test 👍

legalsylvain · 2020-02-12T20:05:40Z

I squashed all the commits. Thanks for your reviews.

legalsylvain · 2020-02-12T20:05:49Z

/ocabot merge

OCA-git-bot · 2020-02-12T20:06:02Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-94-by-legalsylvain-bump-no, awaiting test results.

Signed-off-by legalsylvain

OCA-git-bot · 2020-02-12T20:08:33Z

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-94-by-legalsylvain-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Without this fix, it is impossible to uninstall an addon that removes a model for which we had a `mass.object`.

… translatable, as their translations were not removed. (OCA#12)

Execute tests at the end after the module loading for not failing with a required field not filled by default defined in other modules.

Test coverage

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/it/

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/pt/

Fixes OCA#84

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/pt_BR/

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/zh_CN/

[REF] Update mass_operation_abstract/wizard/mass_operation_wizard_mixin.py Co-Authored-By: David Beal <david.beal@akretion.com>

legalsylvain · 2020-02-24T13:06:11Z

/ocabot merge

OCA-git-bot · 2020-02-24T13:06:23Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-94-by-legalsylvain-bump-no, awaiting test results.

OCA-git-bot · 2020-02-24T13:18:59Z

Congratulations, your PR was merged at 568db06. Thanks a lot for contributing to OCA. ❤️

mowny · 2020-08-25T15:05:00Z

After upgrading from 12 to 13, installing mass_operation_abstract and updating mass_editing, odoo still complains about:

2020-08-25 13:11:23,009 6349 INFO live_20161130_v13_test5_20200824 odoo.modules.loading: Model mass.object is declared but cannot be loaded! (Perhaps a module was partially removed or renamed)

As this is only INFO (and the module seems to work) it's probably not that bad, but it is distracting and I'd like to get rid of it. I just don't know how, so any suggestions are welcome.

legalsylvain added this to the 13.0 milestone Sep 30, 2019

legalsylvain changed the title ~~[WIP][13.0] mig mass editing~~ [13.0] [MIG+REF] mass_editing Oct 3, 2019

legalsylvain mentioned this pull request Oct 3, 2019

[13.0][ADD] mass action #97

Closed

OCA-git-bot mentioned this pull request Oct 3, 2019

Migration to version 13.0 #93

Closed

12 tasks

bealdav reviewed Oct 4, 2019

View reviewed changes

mass_operation_abstract/wizard/mass_operation_wizard_mixin.py Outdated Show resolved Hide resolved

SerpentCS approved these changes Oct 27, 2019

View reviewed changes

tarteo reviewed Dec 20, 2019

View reviewed changes

bealdav approved these changes Dec 20, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels Dec 20, 2019

ivantodorovich approved these changes Feb 4, 2020

View reviewed changes

legalsylvain force-pushed the 13.0-MIG-mass_editing branch from 8196d88 to 93e0976 Compare February 12, 2020 20:05

OCA-git-bot added a commit that referenced this pull request Feb 12, 2020

Merge PR #94 into 13.0

1882d59

Signed-off-by legalsylvain

legalsylvain force-pushed the 13.0-MIG-mass_editing branch from 93e0976 to cd641e2 Compare February 12, 2020 22:30

yajo and others added 21 commits February 24, 2020 13:37

[FIX][mass_editing] Allow to delete models

50d6ca3

Without this fix, it is impossible to uninstall an addon that removes a model for which we had a `mass.object`.

[MIG] mass_editing: Migration to 11.0

515d08c

[FIX] mass_editing : README correction (OCA#11)

aed065b

[FIX] mass_editing: Fixing error when removing value for fields being…

780b4ea

… translatable, as their translations were not removed. (OCA#12)

[FIX] mass_editing: Don't import tests

79e70be

[UPD] Update mass_editing.pot

bd418d1

[IMP] mass_editing: Work with integration tests

aed4445

Execute tests at the end after the module loading for not failing with a required field not filled by default defined in other modules.

[MIG] mass_editing: Migration to 12.0

29e08fc

Test coverage

fixup! [MIG] mass_editing: Migration to 12.0 Test coverage

0312a1f

[UPD] README.rst

ec2efa1

[UPD] Update mass_editing.pot

1c01af5

[UPD] README.rst

979124c

Update translation files

1ecb318

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Translated using Weblate (Italian)

9224fb4

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/it/

Translated using Weblate (Italian)

d3aa2ce

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/it/

Translated using Weblate (Portuguese)

a359bb3

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/pt/

[FIX] mass_editing: Images URLs

04d5b3d

Fixes OCA#84

[UPD] README.rst

decf694

Translated using Weblate (Portuguese (Brazil))

a019eae

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/pt_BR/

Translated using Weblate (Chinese (Simplified))

805dccb

Currently translated at 100.0% (26 of 26 strings) Translation: server-ux-12.0/server-ux-12.0-mass_editing Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-mass_editing/zh_CN/

[PORT] mass_editing in V13

8b71564

[REF] Update mass_operation_abstract/wizard/mass_operation_wizard_mixin.py Co-Authored-By: David Beal <david.beal@akretion.com>

legalsylvain force-pushed the 13.0-MIG-mass_editing branch from 274f110 to 8b71564 Compare February 24, 2020 12:38

OCA-git-bot merged commit 9f46a9c into OCA:13.0 Feb 24, 2020

OCA-git-bot added the merged 🎉 label Feb 24, 2020

legalsylvain mentioned this pull request Nov 20, 2020

[12.0][ADD] report_label OCA/reporting-engine#457

Merged

legalsylvain mentioned this pull request Oct 30, 2024

[16.0][FIX] mass_edit: Play onchanges before writing #963

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0] [MIG+REF] mass_editing #94

[13.0] [MIG+REF] mass_editing #94

legalsylvain commented Sep 30, 2019 •

edited

Loading

oca-clabot commented Sep 30, 2019

legalsylvain commented Oct 3, 2019

legalsylvain commented Oct 3, 2019 •

edited

Loading

SerpentCS commented Oct 26, 2019

legalsylvain commented Oct 26, 2019 •

edited

Loading

SerpentCS commented Oct 27, 2019

tarteo left a comment

legalsylvain commented Dec 20, 2019

legalsylvain commented Dec 20, 2019

bealdav left a comment

OCA-git-bot commented Dec 20, 2019

legalsylvain commented Dec 21, 2019

bealdav commented Dec 21, 2019

MiquelRForgeFlow commented Jan 30, 2020

ivantodorovich left a comment

legalsylvain commented Feb 12, 2020

legalsylvain commented Feb 12, 2020

OCA-git-bot commented Feb 12, 2020

OCA-git-bot commented Feb 12, 2020

legalsylvain commented Feb 24, 2020

OCA-git-bot commented Feb 24, 2020

OCA-git-bot commented Feb 24, 2020

mowny commented Aug 25, 2020

[13.0] [MIG+REF] mass_editing #94

[13.0] [MIG+REF] mass_editing #94

Conversation

legalsylvain commented Sep 30, 2019 • edited Loading

oca-clabot commented Sep 30, 2019

legalsylvain commented Oct 3, 2019

legalsylvain commented Oct 3, 2019 • edited Loading

SerpentCS commented Oct 26, 2019

legalsylvain commented Oct 26, 2019 • edited Loading

SerpentCS commented Oct 27, 2019

tarteo left a comment

Choose a reason for hiding this comment

legalsylvain commented Dec 20, 2019

legalsylvain commented Dec 20, 2019

bealdav left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 20, 2019

legalsylvain commented Dec 21, 2019

bealdav commented Dec 21, 2019

MiquelRForgeFlow commented Jan 30, 2020

ivantodorovich left a comment

Choose a reason for hiding this comment

legalsylvain commented Feb 12, 2020

legalsylvain commented Feb 12, 2020

OCA-git-bot commented Feb 12, 2020

OCA-git-bot commented Feb 12, 2020

legalsylvain commented Feb 24, 2020

OCA-git-bot commented Feb 24, 2020

OCA-git-bot commented Feb 24, 2020

mowny commented Aug 25, 2020

legalsylvain commented Sep 30, 2019 •

edited

Loading

legalsylvain commented Oct 3, 2019 •

edited

Loading

legalsylvain commented Oct 26, 2019 •

edited

Loading