[18.0][MIG] base_technical_features: Migration to 18.0 #953

Kimkhoi3010 · 2024-10-15T04:07:05Z

I found only 1 commit to port but it was ignored, I added it to blacklist: [17.0][FW] base_technical_features: port from 14.0

Reason for change:

The original logic in _postprocess_access_rights removes base.group_no_one for non-admin users, which restricts their access to certain UI components. Extending _get_view ensures that technical users (part of base_technical_features.group_technical_features) still have access to these components without needing full admin privileges.

Using new base model inheritance

Currently translated at 75.0% (6 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/ar/

Currently translated at 75.0% (6 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/da/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/es/

Currently translated at 100,0% (8 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/ca/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/zh_CN/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt_BR/

Currently translated at 87.5% (7 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-14.0/server-ux-14.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_technical_features/es/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-14.0/server-ux-14.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_technical_features/nl/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-16.0/server-ux-16.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_technical_features/es/

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-17.0/server-ux-17.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_technical_features/it/

…sers On databases with a large number of users, loading all users of base.group_no_one can be slow. Moreover, the 'technical_features' and 'show_technical_features' are always computed for a single record

pedrobaeza · 2024-10-15T06:36:30Z

/ocabot migration base_technical_features

chienandalu

Thanks :) Some comments below

base_technical_features/models/base.py

chienandalu · 2024-10-15T07:06:45Z

base_technical_features/models/ir_ui_menu.py

+        """Set debug = True, so that group_no_one is not filtered out of the
+        user's groups"""


That is the docstring available from this commit: 204294

chienandalu · 2024-10-15T07:18:21Z

base_technical_features/models/base.py

-    def user_has_groups(self, groups):
-        """Return True for users in the technical features group when
-        membership of the original group is checked, even if debug mode
-        is not enabled.
+    @api.model
+    def _get_view(self, view_id=None, view_type="form", **options):


Is it enogh to just replace the group in view?

chienandalu · 2024-10-15T07:19:46Z

base_technical_features/models/base.py

+        arch, view = super()._get_view(view_id=view_id, view_type=view_type, **options)
+        arch_str = etree.tostring(arch, encoding="unicode")
+        arch_str = arch_str.replace(
+            "base.group_no_one", "base_technical_features.group_technical_features"


Maybe this would be more correct, as otherwise a user with no base_technical_features.group_technical_features wouldn't access to the regular base.group_no_one behavior in debug mode

Suggested change

"base.group_no_one", "base_technical_features.group_technical_features"

"base.group_no_one", "base.group_no_one,base_technical_features.group_technical_features"

simahawk

LG overall, minor remark.

@chienandalu good for you?

simahawk · 2024-10-24T15:25:46Z

base_technical_features/models/base.py

+    @api.model
+    def _get_view(self, view_id=None, view_type="form", **options):
+        arch, view = super()._get_view(view_id=view_id, view_type=view_type, **options)
+        arch_str = etree.tostring(arch, encoding="unicode")


wouldn't be better to check if the string is there 1st?

chienandalu

👍

pedrobaeza · 2024-10-25T06:58:43Z

/ocabot merge nobump

OCA-git-bot · 2024-10-25T06:58:53Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-953-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-10-25T07:00:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-10-25T07:02:26Z

Congratulations, your PR was merged at 4b35eea. Thanks a lot for contributing to OCA. ❤️

StefanRijnhart and others added 30 commits October 15, 2024 11:05

[ADD] Access to technical features as a user preference

8519f4c

[MIG] base_technical_features -> 10.0 (OCA#568)

d33de4b

Using new base model inheritance

[UPG] 11.0, base_technical_features

1ee3d08

Translated using Weblate (Arabic)

85f9a11

Currently translated at 75.0% (6 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/ar/

Translated using Weblate (Danish)

de1e7b6

Currently translated at 75.0% (6 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/da/

Translated using Weblate (Spanish)

a41a6cf

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/es/

Translated using Weblate (Catalan)

398e1c8

Currently translated at 100,0% (8 of 8 strings) Translation: server-ux-11.0/server-ux-11.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_technical_features/ca/

[12.0-mig-base] [MIG] base_technical_features: Migration to 12.0

df57f10

[FIX] travis error: duplicate implicit target name

566893c

Translated using Weblate (Italian)

857d982

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/

Translated using Weblate (Italian)

8e1ed5b

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/it/

Translated using Weblate (Portuguese)

9642750

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt/

Translated using Weblate (Chinese (Simplified))

4baf10d

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/zh_CN/

Translated using Weblate (Portuguese (Brazil))

b361299

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/pt_BR/

Translated using Weblate (Croatian)

2dcdd1a

Currently translated at 87.5% (7 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

[IMP]base_tchnical_features. Assign automatically to admin not to root

84e30e8

Translated using Weblate (Croatian)

614a5a8

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-12.0/server-ux-12.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_technical_features/hr/

[IMP] base_technical_features: black, isort

f735497

[MIG] base_technical_features: Migration to 13.0

2216d6f

pre-commit update

77ec39b

Added translation using Weblate (Japanese)

ae0ba0e

[MIG] base_technical_features: Migration to 14.0

50bc038

Fix linting

2042944

Fix linting

0a9bdd1

[FIX] base_technical_features: user setting in hidden group

e69057e

Translated using Weblate (Spanish)

9302dd8

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-14.0/server-ux-14.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_technical_features/es/

Translated using Weblate (Dutch)

5848834

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-14.0/server-ux-14.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_technical_features/nl/

[IMP] base_technical_features: black, isort, prettier

2f9e8fa

[MIG] base_technical_features: Migration to 15.0

2ef71f1

[IMP] base_technical_features: black, isort, prettier

4cb8a57

Ivorra78 and others added 9 commits October 15, 2024 11:05

Translated using Weblate (Spanish)

65349fb

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-16.0/server-ux-16.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_technical_features/es/

[IMP] base_technical_features: pre-commit stuff

aa00db3

[MIG] base_technical_features: Migration to 17.0

127579d

[UPD] Update base_technical_features.pot

d030dc8

[BOT] post-merge updates

e8ba83d

[IMP] date_range: pre-commit auto fixes

094bb48

Translated using Weblate (Italian)

8a4269c

Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-17.0/server-ux-17.0-base_technical_features Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_technical_features/it/

[IMP] base_technical_features: use has_group instead of loading all u…

00fc1fc

…sers On databases with a large number of users, loading all users of base.group_no_one can be slow. Moreover, the 'technical_features' and 'show_technical_features' are always computed for a single record

oca-port: blacklist PR(s) 411 for base_technical_features

0ddd2f3

OCA-git-bot added this to the 18.0 milestone Oct 15, 2024

OCA-git-bot mentioned this pull request Oct 15, 2024

Migration to version 18.0 #948

Open

17 tasks

chienandalu suggested changes Oct 15, 2024

View reviewed changes

[MIG] base_technical_features: Migration to 18.0

6de17cf

Kimkhoi3010 force-pushed the 18.0-mig-base_technical_features branch from ac44d8d to 6de17cf Compare October 15, 2024 11:12

Kimkhoi3010 requested a review from chienandalu October 15, 2024 11:13

Kimkhoi3010 mentioned this pull request Oct 16, 2024

[18.0][MIG] base_technical_features: Migration to 18.0 Kimkhoi3010/server-ux#2

Closed

henrybackman approved these changes Oct 22, 2024

View reviewed changes

simahawk approved these changes Oct 24, 2024

View reviewed changes

chienandalu approved these changes Oct 25, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 25, 2024

OCA-git-bot added bot is merging ⏳ ready to merge labels Oct 25, 2024

OCA-git-bot merged commit 91dca12 into OCA:18.0 Oct 25, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] base_technical_features: Migration to 18.0 #953

[18.0][MIG] base_technical_features: Migration to 18.0 #953

Kimkhoi3010 commented Oct 15, 2024 •

edited

Loading

pedrobaeza commented Oct 15, 2024

chienandalu left a comment

chienandalu Oct 15, 2024

Kimkhoi3010 Oct 15, 2024

chienandalu Oct 15, 2024

chienandalu Oct 15, 2024

simahawk left a comment

simahawk Oct 24, 2024

chienandalu left a comment

pedrobaeza commented Oct 25, 2024

OCA-git-bot commented Oct 25, 2024

OCA-git-bot commented Oct 25, 2024

OCA-git-bot commented Oct 25, 2024

		"""Set debug = True, so that group_no_one is not filtered out of the
		user's groups"""

	"base.group_no_one", "base_technical_features.group_technical_features"
	"base.group_no_one", "base.group_no_one,base_technical_features.group_technical_features"

[18.0][MIG] base_technical_features: Migration to 18.0 #953

[18.0][MIG] base_technical_features: Migration to 18.0 #953

Conversation

Kimkhoi3010 commented Oct 15, 2024 • edited Loading

Reason for change:

pedrobaeza commented Oct 15, 2024

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu Oct 15, 2024

Choose a reason for hiding this comment

Kimkhoi3010 Oct 15, 2024

Choose a reason for hiding this comment

chienandalu Oct 15, 2024

Choose a reason for hiding this comment

chienandalu Oct 15, 2024

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

simahawk Oct 24, 2024

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 25, 2024

OCA-git-bot commented Oct 25, 2024

OCA-git-bot commented Oct 25, 2024

OCA-git-bot commented Oct 25, 2024

Kimkhoi3010 commented Oct 15, 2024 •

edited

Loading