Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] mail_tracking: Migration to 16.0 #1029

Closed
wants to merge 122 commits into from

Conversation

hvgollar
Copy link

No description provided.

antespi and others added 30 commits December 12, 2022 15:42
* [ADD] mail_tracking addon

* Add description icon

* Fixes remarked

* Fix Travis error

* Remarks fixed
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
* Improve tests
* Show trackings even if partner removed
* Disable CSRF protection to webhooks controllers
As regular users can't access this object.
* [FIX] Only one data-odoo-tracking-email tag in each email
* [FIX] Get status even in multicompany instances
On our server,
queries based on "mail_tracking_event"."tracking_email_id" improved from 501,924 ms to 1,840 ms
queries based on "mail_tracking_email"."mail_message_id" improved from 167,436 ms to 3,223 ms

The last ones are run several times when a thread has many messages
Currently translated at 100.0% (82 of 82 strings)

Translation: social-11.0/social-11.0-mail_tracking
Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/
For giving more priority to other buttons like the invoices one.
Currently translated at 96.3% (79 of 82 strings)

Translation: social-11.0/social-11.0-mail_tracking
Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/
Or infinite recursions will happen on other `write` overwrites, like the one that happens
on `mass_mailing_partner`.
@hvgollar hvgollar mentioned this pull request Dec 19, 2022
36 tasks
Copy link

@maq-adhoc maq-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the mails fail an error appears when rendering the chatter.

Uncaught Promise > Invalid props for component 'https://github.com/messaging MessageFailedBox': unknown key 'record', 'chatterLocalId' is missing (should be a string)

@nicomacr
Copy link

@hvgollar the error is still present in the module as the last comment said.

@hvgollar
Copy link
Author

@hvgollar the error is still present in the module as the last comment said.

Could help me in reproducing the issue.

@nicolascol
Copy link

nicolascol commented Dec 29, 2022

@hvgollar the error is still present in the module as the last comment said.

Could help me in reproducing the issue.

hi, the error is generated when entering the discuss app
@hvgollar

@rconjour
Copy link

rconjour commented Jan 4, 2023

@hvgollar can you please squash all your commits?

@hvgollar
Copy link
Author

hvgollar commented Jan 4, 2023

@hvgollar can you please squash all your commits?

@rconjour Yes, its done

@nicomacr
Copy link

@hvgollar I faced this bug using the module Promesa desconocida > "Directive t-foreach should always be used with a t-key!" (expression: t-foreach="messagefailed.failed_recipients" t-as="recipient") Is happened when creating an activity.
Could you check the JS part?

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should respect attribution of the changes you're including (cherry-picking or rebasing) not to include those in the migration commit.

@alan196
Copy link

alan196 commented Feb 22, 2023

I tested migration to V16 with a database with this module installed, It's failing to open views with failed messages.

It raises the following error in JS console.


Missing dependencies:     (6) ['mail.Manager.Notification', 'mail.model.AbstractMessage', 'mail.model.Message', 'mail.Discuss', 'mail.Manager', 'mail.model.Mailbox']0: "mail.Manager.Notification"1: "mail.model.AbstractMessage"2: "mail.model.Message"3: "mail.Discuss"4: "mail.Manager"5: "mail.model.Mailbox"length: 6[[Prototype]]: Array(0)
boot.js:347 Non loaded modules:       ['mail_tracking.FailedMessageDiscuss']0: "mail_tracking.FailedMessageDiscuss"length: 1[[Prototype]]: Array(0)
boot.js:355 Debug:                    {mail_tracking.FailedMessageDiscuss: {…}}mail_tracking.FailedMessageDiscuss: {dependencies: Array(8), dependents: Array(0), name: 'mail_tracking.FailedMessageDiscuss', missing: Array(6)}[[Prototype]]: Object
error_service.js:70 OwlError: Got duplicate key in t-foreach: false
    at MessagingClass.template (eval at compile (owl.js:5470:1), <anonymous>:232:51) (/web/static/lib/owl/owl.js:5470)
    at node.renderFn (owl.js:2633:1) (/web/static/lib/owl/owl.js:2633)
    at node.renderFn (owl.js:2642:1) (/web/static/lib/owl/owl.js:2642)
    at Fiber._render (owl.js:1621:1) (/web/static/lib/owl/owl.js:1621)
    at Fiber.render (owl.js:1613:1) (/web/static/lib/owl/owl.js:1613)
    at ComponentNode.initiateRender (owl.js:2352:1) (/web/static/lib/owl/owl.js:2352)

@pedrobaeza
Copy link
Member

Superseded by #1091, as this one is not fully working.

@pedrobaeza pedrobaeza closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.