-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] mail_preview_audio: Migration to 15.0 #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runbot
I think this is worth to be proposed to Odoo upstream to master, don't you think? |
/ocabot migration mail_preview_audio |
I spent some time thinking that it was indeed added in v14 as you can preview some audio files in the core attachments widget (you can with But I was missing the point of the base module that adds a field widget for binary files that allows that previews in place. So the whole binary field widget should be moved to have that. |
I don't quite get you. The idea is to use this preview option in the DMS. If not needed for most audio file (OGG, MP3, OPUS...), then let's get rid off this module. WAV is not so important IMO. |
What core does have already is support for audio files in the attachments widget which this module used to support as well but now delegates to Odoo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 018be18. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT41546
please review @CarlosRoca13
ping @etobella