[MIG] mail_optional_follower_notification: Migration to 18.0 #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] Add mail_optional_follower_notifications module * [CHG][mail_optional_follower_notifications] Readme. * [IMP][mail_optional_follower_notifications] Code review. * [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification * [IMP][mail_optional_follower_notification] Review
…e res.partner and channel
…r_notification and mail_optional_autofollow
…tify instead of notify_followers. Without this commit, followers are NEVER notified when a message is directly posted on the tracker (without click to open the mail compose message form)
Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/de/
Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/pt/
Co-authored-by: Isabelle RICHARD <isabelle.richard@smile.fr>
Currently translated at 50.0% (2 of 4 strings) Translation: social-14.0/social-14.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_optional_follower_notification/es/
Currently translated at 25.0% (1 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_optional_follower_notification/
There was a problem hiding this comment.
Functionally, LGTM. The field in the composer is missing its text, but other than that it, appears to work.
Also, mind taking a look at the last two commits? They are missing the module and version in the commit message. Can you rebase and add the correct information?
| position="before" | ||
| > | ||
| <field | ||
| name="notify_followers" |
There was a problem hiding this comment.
This field is missing it's label. Without it, the checkbox doesn't have any text in the mail composer:
carlosdynapps
force-pushed
the
18.0-mig-mail_optional_follower_notification
branch
3 times, most recently
from
760f53c
to
e55e5c1
Compare
[MIG] mail_optional_follower_notification: Migration to 18.0 [MIG] mail_optional_follower_notification: Migration to 18.0 [MIG] mail_optional_follower_notification: Migration to 18.0
carlosdynapps
force-pushed
the
18.0-mig-mail_optional_follower_notification
branch
from
142af37
to
23622d8
Compare
NachoAlesLopez
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.