[IMP] mass_mailing_custom_unsubscribe: GDPR compliance

[yajo]

• Record resubscriptions too.
• Record action metadata.

@Tecnativa

[pedrobaeza]

This deserves 10.0.2.0.0

[rafaelbn]

@yajo I cannot tested in runbot because (see screenshot)

[yajo]

Lol, that seems like a misconfiguration in runbot's nginx... I'll test locally.

[yajo]

I double-checked this works fine, and added some UX enhacements too.

[chienandalu]

Testing locally:

• I tried to unsubscribe with no reason set, and nothing stopped me from it.
• I unsubscribed and then subscribed again. Then unsubscribing seemed to be not possible from here

[yajo]

The new commit fixes the problems you detected, and besides it adds graph and pivot views for unsubscriptions.

[rafaelbn]

@yajo travis is 🔴

[yajo]

It should go 💚 now

[chienandalu]

Just a little flaw now:

• Given a contact in two lists:
  1. Unsubscribe from list1
  2. Unsubscribe from list2and resubscribe to list1

Everything goes fine except the resubscription log to list1 gets the unsubscription from list2reason.

[yajo]

Good catch, it should be fixed now.

[chienandalu]

Now it won't let me unsubscribe: Your changes have not been saved, try again later

[chienandalu]

A trace here:

odoo_1  | 2018-05-08 12:17:59,655 45 ERROR test odoo.http: Exception during JSON request handling.
odoo_1  | Traceback (most recent call last):
odoo_1  |   File "/opt/odoo/custom/src/odoo/odoo/http.py", line 641, in _handle_exception
odoo_1  |     return super(JsonRequest, self)._handle_exception(exception)
odoo_1  |   File "/opt/odoo/custom/src/odoo/odoo/http.py", line 683, in dispatch
odoo_1  |     result = self._call_function(**self.params)
odoo_1  |   File "/opt/odoo/custom/src/odoo/odoo/http.py", line 333, in _call_function
odoo_1  |     return checked_call(self.db, *args, **kwargs)
odoo_1  |   File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 101, in wrapper
odoo_1  |     return f(dbname, *args, **kwargs)
odoo_1  |   File "/opt/odoo/custom/src/odoo/odoo/http.py", line 326, in checked_call
odoo_1  |     result = self.endpoint(*a, **kw)
odoo_1  |   File "/opt/odoo/custom/src/odoo/odoo/http.py", line 941, in __call__
odoo_1  |     return self.method(*args, **kw)
odoo_1  |   File "/opt/odoo/custom/src/odoo/odoo/http.py", line 506, in response_wrap
odoo_1  |     response = f(*args, **kw)
odoo_1  |   File "/opt/odoo/auto/addons/mass_mailing_custom_unsubscribe/controllers/main.py", line 113, in unsubscribe
odoo_1  |     mailing._unsubscribe_token(res_id, token)
odoo_1  |   File "/opt/odoo/auto/addons/mass_mailing_custom_unsubscribe/models/mail_mass_mailing.py", line 34, in _unsubscribe_token
odoo_1  |     key = (self.env.cr.dbname, self.id, int(res_id))
odoo_1  | TypeError: int() argument must be a string or a number, not 'NoneType'

[yajo]

That's not supposed to happen. It's like you're using a wrong URL to unsubscribe. Are you testing the right way?

[chienandalu]

I'm testing the same way as before:

• create a new mass mailing
• send this mass_mailing to a contact in two lists
• open the link in incognito window
• try to unsubscribe

[yajo]

Make sure you test with real emails, not with test emails. Test email unsubscription shouldn't work.