Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][15.0]mail_activity_board #802

Merged
merged 24 commits into from
Nov 29, 2021
Merged

[MIG][15.0]mail_activity_board #802

merged 24 commits into from
Nov 29, 2021

Conversation

JoanMForgeFlow
Copy link
Contributor

@JoanMForgeFlow JoanMForgeFlow commented Nov 18, 2021 •
edited
Loading

dajuayen and others added 23 commits November 16, 2021 12:02
@dajuayen @JoanMForgeFlow
[ADD][mail_activity_board] Add new module that insert activities boar…
2dda6e2 
…d in boards. (OCA#283)

* [ADD] Module that insert activities board.

* [FIX] Author error in __manifest__ file and style changes.

* [FIX] Fix replace in view, rename files and style changes.

* [FIX] Enumerated list ends without a blank line; unexpected unindent.

* [FIX] Name fail.

* [FIX] Bug in view.

* [FIX]  Add button Activities in mail.thread and readme folder. Others improvements in style of code.

* [FIX] Type 'tree' not found in registry: problem solved.

* [FIX] Dependence change: 'mail' for 'calendar'.

* [FIX] Eliminated unnecessary imports.

* [FIX] Bugs about js and if/else.

* [FIX] Improvements following guide lines and eliminating unnecessary attributes in views.

* [ADD] Added counter in the 'Activities List' button.

* [FIX] Bugs in javascript with 'Activities' button.

* [ADD] Tests folder.

* [FIX] Deleted references to modules not installed.

* [FIX] Formatting javascript.

* [FIX] Bug: added a soft line before a class.

* [FIX] Bug: OCA#283 (comment)

* [FIX] Escaping 'lt' in xml file. Bug: OCA#283 (comment)

* [FIX] The meeting attendees are shown in kanban mode on the meeting board.

* [FIX] Hide in form view of the activity board the assistant field if the activity is not a meeting type or if there are no assistants.

* [FIX] Change to default kanban view for partners.
@OCA-git-bot @JoanMForgeFlow
[UPD] README.rst
acf5839
@oca-travis @JoanMForgeFlow
[UPD] Update mail_activity_board.pot
94c020d
@MiquelRForgeFlow @JoanMForgeFlow
[IMP] mail_activity_board: filter activities by user read permissions
a2ac749
@MiquelRForgeFlow @JoanMForgeFlow
[MIG] mail_activity_board: Migration to 12.0
da464e0
@OCA-git-bot @JoanMForgeFlow
[UPD] README.rst
25fc8e0
@oca-travis @JoanMForgeFlow
[UPD] Update mail_activity_board.pot
8232922
@OCA-git-bot @JoanMForgeFlow
[UPD] README.rst
665fd33
@pegonzalezspesol @JoanMForgeFlow
[MIG] 13.0 mail_activity_board
fd6bc0c
@pegonzalezspesol @MiquelRForgeFlow @JoanMForgeFlow
Update mail_activity_board/__manifest__.py
e0e6b4e 
Co-Authored-By: Miquel Raïch <miquel.raich@eficent.com>
@oca-travis @JoanMForgeFlow
[UPD] Update mail_activity_board.pot
e354f75
@OCA-git-bot @JoanMForgeFlow
[UPD] README.rst
d992aa6
@JoanMForgeFlow
Added translation using Weblate (French)
b915efc
@JoanMForgeFlow
Translated using Weblate (French)
d721beb 
Currently translated at 100.0% (18 of 18 strings)

Translation: social-13.0/social-13.0-mail_activity_board
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_board/fr_BE/
@eduardgm @JoanMForgeFlow
Added translation using Weblate (Spanish)
a9542af
@eduardgm @JoanMForgeFlow
Translated using Weblate (Spanish)
6d9491c 
Currently translated at 88.9% (16 of 18 strings)

Translation: social-13.0/social-13.0-mail_activity_board
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_board/es/
@MiquelRForgeFlow @JoanMForgeFlow
[FIX] solved: unlink issue due to bad migration
ef1beea
@OCA-git-bot @JoanMForgeFlow
mail_activity_board 13.0.1.0.1
de8cbc0
@atchuthan @JoanMForgeFlow
[IMP] : black, isort, prettier
3fe1275
@atchuthan @MiquelRForgeFlow @JoanMForgeFlow
[MIG] mail_activity_board: Migration to 14.0
24ed471 
[FIX] add title to <i> tag and removed console.log in js

Co-authored-by: Miquel Raïch <miquel.raich@forgeflow.com>

Co-authored-by: Miquel Raïch <miquel.raich@forgeflow.com>
@oca-travis @JoanMForgeFlow
[UPD] Update mail_activity_board.pot
fab7196
@OCA-git-bot @JoanMForgeFlow
[UPD] README.rst
206fd0d
@JoanMForgeFlow
[IMP] mail_activity_board: black, isort, prettier
cf0791d
@AaronHForgeFlow
Copy link
Contributor

@OCA/social-maintainers can someone please approve the workflow to run here? Thanks in advance.

AaronHForgeFlow
AaronHForgeFlow suggested changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an error when installing contacts and creating an activity in a partner. That is not happening if I uninstall the module:
2021-11-18_17-48

MiquelRForgeFlow
MiquelRForgeFlow reviewed Nov 22, 2021
View reviewed changes
mail_activity_board/static/src/components/chatter_topbar/chatter_topbar.js Outdated
// --------------------------------------------------------------------------

/**
* @privatez
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @privatez
* @private

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests 👍

@JoanMForgeFlow
Copy link
Contributor Author

Functionally, the module works as it should, but the pre-commit fails with the following error:

3:1 error Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

Anyone have an idea how to solve it?
Thanks in advance
@Tardo
@MiquelRForgeFlow
@AaronHForgeFlow

@AaronHForgeFlow
Copy link
Contributor

I think this may be related to OCA/oca-addons-repo-template#85 @yajo

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

I think this may be related to OCA/oca-addons-repo-template#85 @yajo

after some research, it seems the .js files must be renamed to esm.js. So please diregard my previous message.

@JoanMForgeFlow
Copy link
Contributor Author

I think this may be related to OCA/oca-addons-repo-template#85 @yajo

after some research, it seems the .js files must be renamed to esm.js. So please diregard my previous message.

Solved! Thanks

@dreispt
Copy link
Member

dreispt commented Nov 29, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-802-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ad7caec into OCA:15.0 Nov 29, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 663ad9a. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-mail_activity_board branch November 29, 2021 08:41
@rafaelbn
Copy link
Member

rafaelbn commented Apr 4, 2022

/ocabot migration mail_activity_board

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 4, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 4, 2022
Open
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.