Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] mail_activity_team #833

Merged
merged 34 commits into from
Mar 3, 2022
Merged

[15.0][MIG] mail_activity_team #833

merged 34 commits into from
Mar 3, 2022

Conversation

BernatPForgeFlow
Copy link
Member

@BernatPForgeFlow BernatPForgeFlow commented Jan 19, 2022 •
edited
Loading

Standard migration to 15.0

JordiBForgeFlow and others added 30 commits January 13, 2022 15:38
@JordiBForgeFlow @BernatPForgeFlow
[ADD] mail_activity_team
0d40a4a
@MiquelRForgeFlow @BernatPForgeFlow
[IMP] Some improvements and fixes
542dec7
@MiquelRForgeFlow @BernatPForgeFlow
[ADD] tests
bf55cbc
@MiquelRForgeFlow @BernatPForgeFlow
[MIG] mail_activity_team: Migration to 12.0
8458364
@AdriaGForgeFlow @BernatPForgeFlow
[IMP] Set team responsible as default user when activity is created
45f7b44
@AdriaGForgeFlow @BernatPForgeFlow
[IMP] Add search filter for My Team Activities
6d57e06
@bealdav @BernatPForgeFlow
FIX mail_activ_team: always allow superuser
9179b3f
@oca-travis @BernatPForgeFlow
[UPD] Update mail_activity_team.pot
5fe649a
@OCA-git-bot @BernatPForgeFlow
[UPD] README.rst
99ff710
@OCA-git-bot @BernatPForgeFlow
[UPD] README.rst
f2c27cd
@pegonzalezspesol @BernatPForgeFlow
[IMP] mail_activity_team: black, isort
108a4e7
@pegonzalezspesol @BernatPForgeFlow
[MIG] 13.0 mail_activity_team
2ae59d5
@oca-travis @BernatPForgeFlow
[UPD] Update mail_activity_team.pot
a15e020
@OCA-git-bot @BernatPForgeFlow
[UPD] README.rst
cff5e8d
@alessandro-fiorino @BernatPForgeFlow
Added translation using Weblate (Italian)
75fcd15
@alessandro-fiorino @BernatPForgeFlow
Translated using Weblate (Italian)
7fc5018 
Currently translated at 100.0% (24 of 24 strings)

Translation: social-13.0/social-13.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/it/
@BernatPForgeFlow
[IMP] pre-commit run -a
324d84a
@MiquelRForgeFlow @BernatPForgeFlow
[UPD] Eficent -> ForgeFlow
e2ac86b
@OCA-git-bot @BernatPForgeFlow
[UPD] README.rst
f17ab0b
@chienandalu @BernatPForgeFlow
[FIX] mail_activity_team: scheduled activity
e2ae306 
When an activity is scheduled due to automatic processes the onchanges
won't adapt the proper user team, so we could have a mismatch that
provokes an exceptions due to the designed constaints
@oca-travis @BernatPForgeFlow
[UPD] Update mail_activity_team.pot
0d20330
@OCA-git-bot @BernatPForgeFlow
[UPD] README.rst
deb4d92
@OCA-git-bot @BernatPForgeFlow
mail_activity_team 13.0.1.0.1
5400bf0
@oca-transbot @BernatPForgeFlow
Update translation files
745feb6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-13.0/social-13.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/
@chienandalu @BernatPForgeFlow
[FIX] mail_activity_team: archived users
98ac2d2 
- If a user is archived but there's an automatic activity, the team
check wouldn't locate him. We have to ensure the context.
- When the automatic activity gets a user with no team, we should set
the team to a void one as well.

TT30470
@OCA-git-bot @BernatPForgeFlow
mail_activity_team 13.0.1.0.2
7efedc2
@tfossoul @BernatPForgeFlow
Added translation using Weblate (French)
4abbb9e
@tfossoul @BernatPForgeFlow
Translated using Weblate (French)
9d4f02b 
Currently translated at 32.0% (8 of 25 strings)

Translation: social-13.0/social-13.0-mail_activity_team
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/fr/
@atchuthan @BernatPForgeFlow
[IMP] mail_activity_team: black, isort, prettier
fbe8f6e
@atchuthan @BernatPForgeFlow
[MIG] mail_activity_team: Migration to 14.0
75306bb
AaronHForgeFlow
AaronHForgeFlow reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that issue is also affecting previous versions of the module. Perhaps we can just put that in the roadmap as a future improvement and move forward with this PR.

@etobella
Copy link
Member

/ocabot migration mail_activity_team

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 24, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 24, 2022
Open
36 tasks
@JoanMForgeFlow
Copy link
Contributor

@etobella Could you try to merge again this module?
Thanks!

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-833-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 25, 2022
@OCA-git-bot
Merge PR #833 into 15.0
5d60bad 
Signed-off-by etobella
@OCA-git-bot
Copy link
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-833-by-etobella-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Member

Can you rebase it? Something is failing...

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BernatPForgeFlow
Copy link
Member Author

BernatPForgeFlow commented Feb 25, 2022 •
edited
Loading

@etobella Ready to merge. Thanks.

@oca-clabot
Copy link

Hey @BernatPForgeFlow, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@BernatPForgeFlow
Copy link
Member Author

Now it works as desired. Reviews are welcome!

cc @ForgeFlow
@ChrisOForgeFlow
@etobella

AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍 Issues solved

etobella
etobella approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etobella
Copy link
Member

etobella commented Mar 3, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-833-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5fa27fd into OCA:15.0 Mar 3, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fdb24dc. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-mail_activity_team branch March 3, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@etobella etobella etobella approved these changes

@olgamarcocb olgamarcocb olgamarcocb approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.